[PATCH libdrm] intel: Fix build failure in test_decode.c

[PATCH libdrm] intel: Fix build failure in test_decode.c

[Lauri Kasanen]

Hi list

The recently released libdrm 2.4.37 does not compile the Intel part:

test_decode.c: In function 'compare_batch':
test_decode.c:107: error: implicit declaration of function 'open_memstream'

PS: Please CC me.

Signed-off-by: Lauri Kasanen <cand@gmx.com>
---
 intel/test_decode.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/intel/test_decode.c b/intel/test_decode.c
index c9ab7ad..0fcdf3b 100644
--- a/intel/test_decode.c
+++ b/intel/test_decode.c
@@ -21,6 +21,8 @@
  * IN THE SOFTWARE.
  */
 
+#define _GNU_SOURCE
+
 #include <string.h>
 #include <stdlib.h>
 #include <stdio.h>
-- 
1.7.2.1

Re: [PATCH libdrm] intel: Fix build failure in test_decode.c

[Ben Widawsky]

On Sat, 30 Jun 2012 13:12:45 +0300
Lauri Kasanen <cand@gmx.com> wrote:

> Hi list
> 
> The recently released libdrm 2.4.37 does not compile the Intel part:
> 
> test_decode.c: In function 'compare_batch':
> test_decode.c:107: error: implicit declaration of function 'open_memstream'
> 
> PS: Please CC me.
> 
> Signed-off-by: Lauri Kasanen <cand@gmx.com>
> ---
>  intel/test_decode.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/intel/test_decode.c b/intel/test_decode.c
> index c9ab7ad..0fcdf3b 100644
> --- a/intel/test_decode.c
> +++ b/intel/test_decode.c
> @@ -21,6 +21,8 @@
>   * IN THE SOFTWARE.
>   */
>  
> +#define _GNU_SOURCE
> +
>  #include <string.h>
>  #include <stdlib.h>
>  #include <stdio.h>

I can't reproduce this. Can anyone else confirm this is broken, and if
so that the above patch fixes it?


-- 
Ben Widawsky, Intel Open Source Technology Center

Re: [PATCH libdrm] intel: Fix build failure in test_decode.c

[Lauri Kasanen]

On Mon, 2 Jul 2012 14:54:58 -0700
Ben Widawsky <ben@bwidawsk.net> wrote:

> > +#define _GNU_SOURCE
> > +
> >  #include <string.h>
> >  #include <stdlib.h>
> >  #include <stdio.h>
> 
> I can't reproduce this. Can anyone else confirm this is broken, and if
> so that the above patch fixes it?

See the manpage, it depends on the glibc version. Libdrm is broken on glibc < 2.10.

- Lauri

Re: [PATCH libdrm] intel: Fix build failure in test_decode.c

[Ben Widawsky]

On Tue, 3 Jul 2012 12:21:27 +0300
Lauri Kasanen <cand@gmx.com> wrote:

> On Mon, 2 Jul 2012 14:54:58 -0700
> Ben Widawsky <ben@bwidawsk.net> wrote:
> 
> > > +#define _GNU_SOURCE
> > > +
> > >  #include <string.h>
> > >  #include <stdlib.h>
> > >  #include <stdio.h>
> > 
> > I can't reproduce this. Can anyone else confirm this is broken, and if
> > so that the above patch fixes it?
> 
> See the manpage, it depends on the glibc version. Libdrm is broken on glibc < 2.10.
> 
> - Lauri
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

Pushed. Thanks for the patch.

-- 
Ben Widawsky, Intel Open Source Technology Center