[PATCH 2/2] staging/comedi/drivers: free allocated priv and release resources if comedi_alloc_subdevices

[PATCH 2/2] staging/comedi/drivers: free allocated priv and release resources if comedi_alloc_subdevices

[Devendra Naga]

as comedi_alloc_subdevices may fail, we leak out the memory allocated by alloc_private,
and also the I/O regions we requested.

free out the private data pointer of the driver, and release the I/O regions.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
 drivers/staging/comedi/drivers/fl512.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
index 52e6d14..6538497 100644
--- a/drivers/staging/comedi/drivers/fl512.c
+++ b/drivers/staging/comedi/drivers/fl512.c
@@ -135,8 +135,11 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 #endif
 
 	ret = comedi_alloc_subdevices(dev, 2);
-	if (ret)
+	if (ret) {
+		kfree(dev);
+		release_region(iobase, FL512_SIZE);
 		return ret;
+	}
 
 	/*
 	 * this if the definitions of the supdevices, 2 have been defined
-- 
1.7.9.5

Re: [PATCH 2/2] staging/comedi/drivers: free allocated priv and release resources if comedi_alloc_subdevices

[Dan Carpenter]

On Sun, Jul 01, 2012 at 07:08:40PM +0530, Devendra Naga wrote:
> as comedi_alloc_subdevices may fail, we leak out the memory allocated by alloc_private,
> and also the I/O regions we requested.
> 
> free out the private data pointer of the driver, and release the I/O regions.
> 
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
> ---

Please drop this.  Devendra sent a v2 of this.

Devendra, please reply to the thread when you want a patch to be
dropped.  Don't make other people (me) clean up for you.

regards,
dan carpenter

Re: [PATCH 2/2] staging/comedi/drivers: free allocated priv and release resources if comedi_alloc_subdevices

[devendra.aaru]

Hi Dan,

On Sun, Jul 1, 2012 at 8:59 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Sun, Jul 01, 2012 at 07:08:40PM +0530, Devendra Naga wrote:
>> as comedi_alloc_subdevices may fail, we leak out the memory allocated by alloc_private,
>> and also the I/O regions we requested.
>>
>> free out the private data pointer of the driver, and release the I/O regions.
>>
>> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
>> ---
>
> Please drop this.  Devendra sent a v2 of this.
>
> Devendra, please reply to the thread when you want a patch to be
> dropped.  Don't make other people (me) clean up for you.
>
sorry about that, i will say from now.
> regards,
> dan carpenter
>

Thanks,