From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org, Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH v2] regulator: fixed: support deferred probe for DT GPIOs
Date: Sun, 1 Jul 2012 19:23:00 +0100 [thread overview]
Message-ID: <20120701182300.GE28922@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1340987595-11288-1-git-send-email-swarren@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On Fri, Jun 29, 2012 at 10:33:15AM -0600, Stephen Warren wrote:
> of_get_named_gpio() needs the driver hosting the GPIO that the DT
> property references to have been probed. Detect this specific failure,
> and defer the probe of the whole regulator until this API can complete.
I've applied this but...
> + /*
> + * of_get_named_gpio() currently returns ENODEV rather than
> + * EPROBE_DEFER. This code attempts to be compatible with both
> + * for now; the ENODEV check can be removed once the API is fixed.
...this just seems rubbish, why aren't we just fixing the device tree
code and why are we doing this at the device tree level rather than as a
general gpiolib thing?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-01 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 16:33 [PATCH v2] regulator: fixed: support deferred probe for DT GPIOs Stephen Warren
2012-07-01 18:23 ` Mark Brown [this message]
2012-07-02 15:40 ` Stephen Warren
2012-07-02 16:03 ` Mark Brown
2012-07-02 16:08 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120701182300.GE28922@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.