From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org, Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH v2] regulator: fixed: support deferred probe for DT GPIOs
Date: Mon, 2 Jul 2012 17:03:40 +0100 [thread overview]
Message-ID: <20120702160340.GG25093@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FF1C0D6.3010108@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
On Mon, Jul 02, 2012 at 09:40:06AM -0600, Stephen Warren wrote:
> On 07/01/2012 12:23 PM, Mark Brown wrote:
> > ...this just seems rubbish, why aren't we just fixing the device
> > tree code and why are we doing this at the device tree level rather
> > than as a general gpiolib thing?
> It is being fixed in the DT code:
> https://lkml.org/lkml/2012/6/18/468
Is that patch actually being applied (especially with Grant's free time
issues)? I've still got the patch sitting in my inbox since it wasn't
clear what was going on.
> However, it seemed best to make the regulator code work both before
> and after that patch.
I'd be kind of inclined to just leave it broken to be honest rather than
having a huge comment and dodgy code.
> This issue can't be fixed only in gpio_request(); of_get_named_gpio()
> needs the GPIO driver to be probed/registered to even be able to parse
> the GPIO ID out of the DT; it makes a call into the GPIO driver as
Oh, ick. :/
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-02 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 16:33 [PATCH v2] regulator: fixed: support deferred probe for DT GPIOs Stephen Warren
2012-07-01 18:23 ` Mark Brown
2012-07-02 15:40 ` Stephen Warren
2012-07-02 16:03 ` Mark Brown [this message]
2012-07-02 16:08 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120702160340.GG25093@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.