From: Josh Triplett <josh@joshtriplett.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Alex Kelly <alex.page.kelly@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Eric Paris <eparis@redhat.com>, WANG Cong <amwang@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>, Nikhil Rao <ncrao@google.com>,
Dan Ballard <dan@mindstab.net>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Alex <eshink@gmail.com>
Subject: Re: [PATCH 2/2] Made core dump functionality optional
Date: Mon, 2 Jul 2012 22:09:08 -0700 [thread overview]
Message-ID: <20120703050908.GA14527@leaf> (raw)
In-Reply-To: <CAM_iQpVu6DV+LnTNbDUxUmjA+NXM2WCwWB0StCh+bwD5Gn_zbg@mail.gmail.com>
On Tue, Jul 03, 2012 at 12:55:52PM +0800, Cong Wang wrote:
> On Tue, Jul 3, 2012 at 8:38 AM, Alex Kelly <alex.page.kelly@gmail.com> wrote:
> > From: Alex <eshink@gmail.com>
> >
> > Adds an expert Kconfig option, CONFIG_COREDUMP, which allows disabling of core dump.
> > This saves approximately 2.6k in the compiled kernel, and complements CONFIG_ELF_CORE,
> > which now depends on it.
> >
> > CONFIG_COREDUMP also disables coredump-related sysctls, except for suid_dumpable and
> > related functions, which are necessary for ptrace.
> >
> > Signed-off-by: Alex Kelly <alex.page.kelly@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>
> Looks good, just one nitpick: would CONFIG_CORE_DUMP be better than
> CONFIG_COREDUMP?
The kernel seems pretty split on that question, according to git grep;
"coredump" appears sufficiently often that changing the config option
name doesn't seem worth respinning the patch for.
- Josh Triplett
next prev parent reply other threads:[~2012-07-03 5:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 0:38 [PATCH 1/2] Moved core dump functionality into its own file Alex Kelly
2012-07-03 0:38 ` [PATCH 2/2] Made core dump functionality optional Alex Kelly
2012-07-03 4:55 ` Cong Wang
2012-07-03 5:09 ` Josh Triplett [this message]
[not found] ` <CAH08tp_5CNnK68G4BpZ+d_V9OMwEt8hC_pbtNovgSCTnGYd0hg@mail.gmail.com>
2012-07-13 3:22 ` Cong Wang
2012-07-03 4:53 ` [PATCH 1/2] Moved core dump functionality into its own file Cong Wang
2012-07-13 22:02 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2012-08-01 2:23 Alex Kelly
2012-08-01 2:24 ` [PATCH 2/2] Made core dump functionality optional Alex Kelly
2012-08-03 21:03 [PATCH 1/2] Moved core dump functionality into its own file Alex Kelly
2012-08-03 21:03 ` [PATCH 2/2] Made core dump functionality optional Alex Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703050908.GA14527@leaf \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=alex.page.kelly@gmail.com \
--cc=amwang@redhat.com \
--cc=dan@mindstab.net \
--cc=eparis@redhat.com \
--cc=eshink@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ncrao@google.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.