All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk,
	snitzer@redhat.com, martin.petersen@oracle.com,
	david@fromorbit.com, xfs@oss.sgi.com, dm-devel@redhat.com,
	hch@lst.de
Subject: Re: [dm-devel] [PATCH v2 1/3] block: add sysfs entry for discard_alignment
Date: Tue, 3 Jul 2012 10:00:48 -0400	[thread overview]
Message-ID: <20120703140048.GC11272@redhat.com> (raw)
In-Reply-To: <4FF2DCB1.2090704@redhat.com>

On Tue, Jul 03, 2012 at 01:51:13PM +0200, Paolo Bonzini wrote:
> Il 03/07/2012 04:34, Vivek Goyal ha scritto:
> >> > The next patches will actually use the alignment, expose it in sysfs
> >> > for ease of debugging.
> >> > 
> > Don't we already have discard_alignment exported as device attribute.
> > 
> > /sys/block/<dev>/discard_alignment
> 
> Ah, interesting, I missed it completely.  I guess it's because queue/
> directories only exist for full disks, and the correct alignment varies
> for each partition.  So this patch is unnecessary.

Partition discard_alignments are available in
/sys/block/<disk>/<partition>/discard_alignment.

That raises an interesting question for patch3. If the discard is happening to
a partition, shouldn't you be looking at partition discard_alignment
instead of always looking at queue discard_alignment?

Thanks
Vivek

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: axboe@kernel.dk, martin.petersen@oracle.com, snitzer@redhat.com,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	dm-devel@redhat.com, hch@lst.de
Subject: Re: [dm-devel] [PATCH v2 1/3] block: add sysfs entry for discard_alignment
Date: Tue, 3 Jul 2012 10:00:48 -0400	[thread overview]
Message-ID: <20120703140048.GC11272@redhat.com> (raw)
In-Reply-To: <4FF2DCB1.2090704@redhat.com>

On Tue, Jul 03, 2012 at 01:51:13PM +0200, Paolo Bonzini wrote:
> Il 03/07/2012 04:34, Vivek Goyal ha scritto:
> >> > The next patches will actually use the alignment, expose it in sysfs
> >> > for ease of debugging.
> >> > 
> > Don't we already have discard_alignment exported as device attribute.
> > 
> > /sys/block/<dev>/discard_alignment
> 
> Ah, interesting, I missed it completely.  I guess it's because queue/
> directories only exist for full disks, and the correct alignment varies
> for each partition.  So this patch is unnecessary.

Partition discard_alignments are available in
/sys/block/<disk>/<partition>/discard_alignment.

That raises an interesting question for patch3. If the discard is happening to
a partition, shouldn't you be looking at partition discard_alignment
instead of always looking at queue discard_alignment?

Thanks
Vivek

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-07-03 14:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 13:20 [PATCH v2 0/3] block: improvements for discard alignment Paolo Bonzini
2012-07-02 13:20 ` Paolo Bonzini
2012-07-02 13:20 ` [PATCH v2 1/3] block: add sysfs entry for discard_alignment Paolo Bonzini
2012-07-02 13:20   ` Paolo Bonzini
2012-07-03  2:34   ` [dm-devel] " Vivek Goyal
2012-07-03  2:34     ` Vivek Goyal
2012-07-03  3:59     ` Mike Snitzer
2012-07-03  3:59       ` Mike Snitzer
2012-07-03 11:51     ` [dm-devel] " Paolo Bonzini
2012-07-03 11:51       ` Paolo Bonzini
2012-07-03 14:00       ` Vivek Goyal [this message]
2012-07-03 14:00         ` Vivek Goyal
2012-07-03 14:21         ` Paolo Bonzini
2012-07-03 14:21           ` Paolo Bonzini
2012-07-03 14:39           ` Vivek Goyal
2012-07-03 14:39             ` Vivek Goyal
2012-07-03 14:40             ` Paolo Bonzini
2012-07-03 14:40               ` Paolo Bonzini
2012-07-03 14:45               ` Vivek Goyal
2012-07-03 14:45                 ` Vivek Goyal
2012-07-02 13:20 ` [PATCH v2 2/3] block: reorganize rounding of max_discard_sectors Paolo Bonzini
2012-07-02 13:20   ` Paolo Bonzini
2012-07-03  2:49   ` [dm-devel] " Vivek Goyal
2012-07-03  2:49     ` Vivek Goyal
2012-07-03 11:47     ` Paolo Bonzini
2012-07-03 11:47       ` Paolo Bonzini
2012-07-02 13:20 ` [PATCH v2 3/3] block: split discard into aligned requests Paolo Bonzini
2012-07-02 13:20   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120703140048.GC11272@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=david@fromorbit.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=snitzer@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.