From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlegacy: don't mess up the SCD when removing a key
Date: Wed, 4 Jul 2012 13:22:08 +0200 [thread overview]
Message-ID: <20120704112208.GB2570@redhat.com> (raw)
In-Reply-To: <1341228681-19358-1-git-send-email-emmanuel.grumbach@intel.com>
On Mon, Jul 02, 2012 at 02:31:21PM +0300, Emmanuel Grumbach wrote:
> When we remove a key, we put a key index which was supposed
> to tell the fw that we are actually removing the key. But
> instead the fw took that index as a valid index and messed
> up the SRAM of the device.
>
> This memory corruption on the device mangled the data of
> the SCD. The impact on the user is that SCD queue 2 got
> stuck after having removed keys.
>
> Change-Id: I721f71c1a3a0af6058abe1975cebd9b613c7ff2b
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> ---
> Paul, can you please test ?
> If it solve the issues for you, I will send as a patch and Cc stable Totally not tested
> v2: first hunk of this patch thanks to Stanislaw's review
I tested that patch and did not found any problem.
Stanislaw
next prev parent reply other threads:[~2012-07-04 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 11:31 [PATCH] iwlegacy: don't mess up the SCD when removing a key Emmanuel Grumbach
2012-07-04 11:22 ` Stanislaw Gruszka [this message]
2012-07-04 11:33 ` Emmanuel Grumbach
2012-07-04 11:40 ` Stanislaw Gruszka
2012-07-04 11:49 ` Grumbach, Emmanuel
2012-07-04 12:03 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704112208.GB2570@redhat.com \
--to=sgruszka@redhat.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.