Re: [PATCH] iwlegacy: don't mess up the SCD when removing a key

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Wed, Jul 04, 2012 at 02:33:48PM +0300, Emmanuel Grumbach wrote:
> > On Mon, Jul 02, 2012 at 02:31:21PM +0300, Emmanuel Grumbach wrote:
> > > When we remove a key, we put a key index which was supposed
> > > to tell the fw that we are actually removing the key. But
> > > instead the fw took that index as a valid index and messed
> > > up the SRAM of the device.
> > >
> > > This memory corruption on the device mangled the data of
> > > the SCD. The impact on the user is that SCD queue 2 got
> > > stuck after having removed keys.
> > >
> > > Change-Id: I721f71c1a3a0af6058abe1975cebd9b613c7ff2b
> > > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> > > ---
> > > Paul, can you please test ?
> > > If it solve the issues for you, I will send as a patch and Cc stable
> > > Totally not tested
> > > v2: first hunk of this patch thanks to Stanislaw's review
> >
> > I tested that patch and did not found any problem.
> >
> 
> Ok, but doest it solve the bug ?

CCing Poul.

But even if not, we still probably need that patch, right? Or is
possible that 4965 firmware do not corrupt memory when we provide
wrong key offset to it? Or maybe for 4965 key offset 0xff is something
that is expected and needed to invalidate the key?

Stanislaw