* Re: [PATCH] ASoC: fsl: remove unneeded AUDMUX register setting from imx-sgtl5000 [not found] <1341387507-21015-1-git-send-email-jason77.wang@gmail.com> @ 2012-07-05 1:33 ` Shawn Guo 2012-07-05 12:47 ` Mark Brown 1 sibling, 0 replies; 2+ messages in thread From: Shawn Guo @ 2012-07-05 1:33 UTC (permalink / raw) To: Hui Wang; +Cc: alsa-devel, broonie On Wed, Jul 04, 2012 at 03:38:27PM +0800, Hui Wang wrote: > If we don't set IMX_AUDMUX_V2_PTCR_TCLKDIR in the AUDMUX PTCR > register (means Tx clock pin is input), we don't need to set > IMX_AUDMUX_V2_PTCR_TCSEL as well. Since both i.MX35, i.MX51 and > i.MX6 datasheet says "When Tx clock pin set as an input, the TCSEL > settings are ignored". > > Signed-off-by: Hui Wang <jason77.wang@gmail.com> Acked-by: Shawn Guo <shawn.guo@linaro.org> > --- > sound/soc/fsl/imx-sgtl5000.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c > index 3a729ca..fb21b17 100644 > --- a/sound/soc/fsl/imx-sgtl5000.c > +++ b/sound/soc/fsl/imx-sgtl5000.c > @@ -95,8 +95,7 @@ static int __devinit imx_sgtl5000_probe(struct platform_device *pdev) > return ret; > } > imx_audmux_v2_configure_port(ext_port, > - IMX_AUDMUX_V2_PTCR_SYN | > - IMX_AUDMUX_V2_PTCR_TCSEL(int_port), > + IMX_AUDMUX_V2_PTCR_SYN, > IMX_AUDMUX_V2_PDCR_RXDSEL(int_port)); > if (ret) { > dev_err(&pdev->dev, "audmux external port setup failed\n"); > -- > 1.7.6 > ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: fsl: remove unneeded AUDMUX register setting from imx-sgtl5000 [not found] <1341387507-21015-1-git-send-email-jason77.wang@gmail.com> 2012-07-05 1:33 ` [PATCH] ASoC: fsl: remove unneeded AUDMUX register setting from imx-sgtl5000 Shawn Guo @ 2012-07-05 12:47 ` Mark Brown 1 sibling, 0 replies; 2+ messages in thread From: Mark Brown @ 2012-07-05 12:47 UTC (permalink / raw) To: Hui Wang; +Cc: alsa-devel, shawn.guo [-- Attachment #1.1: Type: text/plain, Size: 363 bytes --] On Wed, Jul 04, 2012 at 03:38:27PM +0800, Hui Wang wrote: > If we don't set IMX_AUDMUX_V2_PTCR_TCLKDIR in the AUDMUX PTCR > register (means Tx clock pin is input), we don't need to set > IMX_AUDMUX_V2_PTCR_TCSEL as well. Since both i.MX35, i.MX51 and > i.MX6 datasheet says "When Tx clock pin set as an input, the TCSEL > settings are ignored". Applied, thanks. [-- Attachment #1.2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-05 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1341387507-21015-1-git-send-email-jason77.wang@gmail.com>
2012-07-05 1:33 ` [PATCH] ASoC: fsl: remove unneeded AUDMUX register setting from imx-sgtl5000 Shawn Guo
2012-07-05 12:47 ` Mark Brown
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.