From: Wanpeng Li <liwp.linux@gmail.com>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memcg: swappiness should between 0 and 100
Date: Fri, 6 Jul 2012 13:24:21 +0800 [thread overview]
Message-ID: <20120706052421.GC5929@kernel> (raw)
In-Reply-To: <20120706051642.GA29829@shangw>
On Fri, Jul 06, 2012 at 01:16:43PM +0800, Gavin Shan wrote:
>On Fri, Jul 06, 2012 at 12:51:52PM +0800, Wanpeng Li wrote:
>>From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>>
>>Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
>>---
>> mm/memcontrol.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>>diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>>index 5e4d1ab..69a7d45 100644
>>--- a/mm/memcontrol.c
>>+++ b/mm/memcontrol.c
>>@@ -4176,7 +4176,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft,
>> struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp);
>> struct mem_cgroup *parent;
>>
>>- if (val > 100)
>>+ if (val > 100 || val < 0)
>
>Wanpeng, the "val" was defined as "u64". So how it could be less than 0?
>
>static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft,
> u64 val)
>
Oh, thank you! Just ignore this patch.
Regards,
Wanpeng Li
>Thanks,
>Gavin
>
>> return -EINVAL;
>>
>> if (cgrp->parent == NULL)
>>--
>>1.7.5.4
>>
>>--
>>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>>the body to majordomo@kvack.org. For more info on Linux MM,
>>see: http://www.linux-mm.org/ .
>>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Wanpeng Li <liwp.linux@gmail.com>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memcg: swappiness should between 0 and 100
Date: Fri, 6 Jul 2012 13:24:21 +0800 [thread overview]
Message-ID: <20120706052421.GC5929@kernel> (raw)
In-Reply-To: <20120706051642.GA29829@shangw>
On Fri, Jul 06, 2012 at 01:16:43PM +0800, Gavin Shan wrote:
>On Fri, Jul 06, 2012 at 12:51:52PM +0800, Wanpeng Li wrote:
>>From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>>
>>Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
>>---
>> mm/memcontrol.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>>diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>>index 5e4d1ab..69a7d45 100644
>>--- a/mm/memcontrol.c
>>+++ b/mm/memcontrol.c
>>@@ -4176,7 +4176,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft,
>> struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp);
>> struct mem_cgroup *parent;
>>
>>- if (val > 100)
>>+ if (val > 100 || val < 0)
>
>Wanpeng, the "val" was defined as "u64". So how it could be less than 0?
>
>static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft,
> u64 val)
>
Oh, thank you! Just ignore this patch.
Regards,
Wanpeng Li
>Thanks,
>Gavin
>
>> return -EINVAL;
>>
>> if (cgrp->parent == NULL)
>>--
>>1.7.5.4
>>
>>--
>>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>>the body to majordomo@kvack.org. For more info on Linux MM,
>>see: http://www.linux-mm.org/ .
>>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>>
next prev parent reply other threads:[~2012-07-06 5:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 4:51 [PATCH] mm/memcg: swappiness should between 0 and 100 Wanpeng Li
2012-07-06 4:51 ` Wanpeng Li
2012-07-06 5:00 ` Gavin Shan
2012-07-06 5:00 ` Gavin Shan
2012-07-06 5:04 ` Gavin Shan
2012-07-06 5:04 ` Gavin Shan
2012-07-06 5:04 ` Gavin Shan
2012-07-06 5:08 ` Wanpeng Li
2012-07-06 5:08 ` Wanpeng Li
2012-07-06 5:08 ` Wanpeng Li
2012-07-06 5:16 ` Gavin Shan
2012-07-06 5:16 ` Gavin Shan
2012-07-06 5:24 ` Wanpeng Li [this message]
2012-07-06 5:24 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706052421.GC5929@kernel \
--to=liwp.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.