All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "AnilKumar, Chimata" <anilkumar@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Cousson, Benoit" <b-cousson@ti.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] arm/dts: Add initial DT support for AM33XX SoC family
Date: Fri, 6 Jul 2012 00:24:13 -0700	[thread overview]
Message-ID: <20120706072412.GK1122@atomide.com> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13E9EF09F@DBDE01.ent.ti.com>

Hi,

* AnilKumar, Chimata <anilkumar@ti.com> [120705 01:21]:
> 
> I realized that for mcspi and mmc, the compatible name supposed tobe close to
> omap4-mcspi. 
> These changes seems to went from my local branch, so could you please merge 
> below patch with this
> 5fc0b42a98556bd9f01cecc6a64fcbd15ec363f0 "arm/dts: Add initial DT
> support for AM33XX SoC family"

I don't quite follow, do you mean you want to change some compatible names?
Your patch is just removing entries though?

Anyways, please just send a fix with a proper description and Signed-off-by
on top of the devel-dt branch.

Regards,

Tony 
 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 1e7b98f..258b10e 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -166,36 +166,5 @@
>                         #size-cells = <0>;
>                         ti,hwmods = "i2c3";
>                 };
> -
> -               mcspi1: spi@48030000 {
> -                       compatible = "ti,omap2-mcspi";
> -                       #address-cells = <1>;
> -                       #size-cells = <0>;
> -                       ti,hwmods = "spi0";
> -                       ti,spi-num-cs = <4>;
> -               };
> -
> -               mcspi2: spi@481Aa000 {
> -                       compatible = "ti,omap2-mcspi";
> -                       #address-cells = <1>;
> -                       #size-cells = <0>;
> -                       ti,hwmods = "spi1";
> -                       ti,spi-num-cs = <2>;
> -               };
> -
> -               mmc1: mmc@48060000 {
> -                       compatible = "ti,omap3-hsmmc";
> -                       ti,hwmods = "mmc1";
> -               };
> -
> -               mmc2: mmc@481D8000 {
> -                       compatible = "ti,omap3-hsmmc";
> -                       ti,hwmods = "mmc2";
> -               };
> -
> -               mmc3: mmc@47810000 {
> -                       compatible = "ti,omap3-hsmmc";
> -                       ti,hwmods = "mmc3";
> -               };
>         };
>  };
> --
> 
> Thanks
> AnilKumar

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] arm/dts: Add initial DT support for AM33XX SoC family
Date: Fri, 6 Jul 2012 00:24:13 -0700	[thread overview]
Message-ID: <20120706072412.GK1122@atomide.com> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13E9EF09F@DBDE01.ent.ti.com>

Hi,

* AnilKumar, Chimata <anilkumar@ti.com> [120705 01:21]:
> 
> I realized that for mcspi and mmc, the compatible name supposed tobe close to
> omap4-mcspi. 
> These changes seems to went from my local branch, so could you please merge 
> below patch with this
> 5fc0b42a98556bd9f01cecc6a64fcbd15ec363f0 "arm/dts: Add initial DT
> support for AM33XX SoC family"

I don't quite follow, do you mean you want to change some compatible names?
Your patch is just removing entries though?

Anyways, please just send a fix with a proper description and Signed-off-by
on top of the devel-dt branch.

Regards,

Tony 
 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 1e7b98f..258b10e 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -166,36 +166,5 @@
>                         #size-cells = <0>;
>                         ti,hwmods = "i2c3";
>                 };
> -
> -               mcspi1: spi at 48030000 {
> -                       compatible = "ti,omap2-mcspi";
> -                       #address-cells = <1>;
> -                       #size-cells = <0>;
> -                       ti,hwmods = "spi0";
> -                       ti,spi-num-cs = <4>;
> -               };
> -
> -               mcspi2: spi at 481Aa000 {
> -                       compatible = "ti,omap2-mcspi";
> -                       #address-cells = <1>;
> -                       #size-cells = <0>;
> -                       ti,hwmods = "spi1";
> -                       ti,spi-num-cs = <2>;
> -               };
> -
> -               mmc1: mmc at 48060000 {
> -                       compatible = "ti,omap3-hsmmc";
> -                       ti,hwmods = "mmc1";
> -               };
> -
> -               mmc2: mmc at 481D8000 {
> -                       compatible = "ti,omap3-hsmmc";
> -                       ti,hwmods = "mmc2";
> -               };
> -
> -               mmc3: mmc at 47810000 {
> -                       compatible = "ti,omap3-hsmmc";
> -                       ti,hwmods = "mmc3";
> -               };
>         };
>  };
> --
> 
> Thanks
> AnilKumar

  reply	other threads:[~2012-07-06  7:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22  9:40 [PATCH 0/3] Add device tree support to AM33XX SoC AnilKumar Ch
2012-06-22  9:40 ` AnilKumar Ch
2012-06-22  9:40 ` [PATCH 1/4] Revert "arm/dts: Add support for TI AM335x EVM board" AnilKumar Ch
2012-06-22  9:40   ` AnilKumar Ch
2012-07-02  8:40   ` Tony Lindgren
2012-07-02  8:40     ` Tony Lindgren
2012-07-02  8:44     ` Vaibhav Hiremath
2012-07-02  8:44       ` Vaibhav Hiremath
2012-07-03 10:29       ` AnilKumar, Chimata
2012-07-03 10:29         ` AnilKumar, Chimata
2012-07-03 11:18         ` Tony Lindgren
2012-07-03 11:18           ` Tony Lindgren
2012-06-22  9:40 ` [PATCH 2/4] arm/dts: Add initial DT support for AM33XX SoC family AnilKumar Ch
2012-06-22  9:40   ` AnilKumar Ch
2012-07-05  8:16   ` AnilKumar, Chimata
2012-07-05  8:16     ` AnilKumar, Chimata
2012-07-06  7:24     ` Tony Lindgren [this message]
2012-07-06  7:24       ` Tony Lindgren
2012-06-22  9:40 ` [PATCH 3/4] arm/dts: Add support for AM335x EVM AnilKumar Ch
2012-06-22  9:40   ` AnilKumar Ch
2012-06-22  9:40 ` [PATCH 4/4] arm/dts: Add support for AM335x BeagleBone AnilKumar Ch
2012-06-22  9:40   ` AnilKumar Ch
2012-06-28 10:01 ` [PATCH 0/3] Add device tree support to AM33XX SoC AnilKumar, Chimata
2012-06-28 10:01   ` AnilKumar, Chimata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120706072412.GK1122@atomide.com \
    --to=tony@atomide.com \
    --cc=anilkumar@ti.com \
    --cc=b-cousson@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.