From: Wanpeng Li <liwp.linux@gmail.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Wanpeng Li <liwp.linux@gmail.com>
Subject: Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset
Date: Fri, 6 Jul 2012 16:44:15 +0800 [thread overview]
Message-ID: <20120706084415.GB9319@kernel> (raw)
In-Reply-To: <20120706082242.GA1230@cmpxchg.org>
On Fri, Jul 06, 2012 at 10:22:42AM +0200, Johannes Weiner wrote:
>On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote:
>> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>>
>> Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT.
>
>And nobody is passing anything else. Which is easy to prove as this
>is a private function. And there wouldn't even be any harm passing
>something else. Please don't add stuff like this.
Ok, thank you for your comment.
I also have another two patches, title:
clarify type in memory cgroups
return -EBUSY when oom-kill-disable modified and memcg use_hierarchy, has children
Hopefully, you can review. Thank you Johannes! :-)
Regards,
Wanpeng Li
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Wanpeng Li <liwp.linux@gmail.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Wanpeng Li <liwp.linux@gmail.com>
Subject: Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset
Date: Fri, 6 Jul 2012 16:44:15 +0800 [thread overview]
Message-ID: <20120706084415.GB9319@kernel> (raw)
In-Reply-To: <20120706082242.GA1230@cmpxchg.org>
On Fri, Jul 06, 2012 at 10:22:42AM +0200, Johannes Weiner wrote:
>On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote:
>> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>>
>> Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT.
>
>And nobody is passing anything else. Which is easy to prove as this
>is a private function. And there wouldn't even be any harm passing
>something else. Please don't add stuff like this.
Ok, thank you for your comment.
I also have another two patches, title:
clarify type in memory cgroups
return -EBUSY when oom-kill-disable modified and memcg use_hierarchy, has children
Hopefully, you can review. Thank you Johannes! :-)
Regards,
Wanpeng Li
next prev parent reply other threads:[~2012-07-06 8:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 3:44 [PATCH] mm/memcg: add BUG() to mem_cgroup_reset Wanpeng Li
2012-07-06 3:44 ` Wanpeng Li
2012-07-06 5:19 ` Gavin Shan
2012-07-06 5:19 ` Gavin Shan
2012-07-06 5:37 ` Wanpeng Li
2012-07-06 5:37 ` Wanpeng Li
[not found] ` <1341546297-6223-1-git-send-email-liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-07-06 8:22 ` Johannes Weiner
2012-07-06 8:22 ` Johannes Weiner
2012-07-06 8:22 ` Johannes Weiner
2012-07-06 8:44 ` Wanpeng Li [this message]
2012-07-06 8:44 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706084415.GB9319@kernel \
--to=liwp.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.