From: "Eric Bénard" <eric@eukrea.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: linux-kernel@vger.kernel.org, nicolas.ferre@atmel.com,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
davem@davemloft.net, nicolas@eukrea.com
Subject: Re: [PATCH 2/5] crypto: add Atmel AES driver
Date: Fri, 6 Jul 2012 15:25:21 +0200 [thread overview]
Message-ID: <20120706152521.5145f1aa@eb-e6520> (raw)
In-Reply-To: <20120706121719.GD4450@game.jcrosoft.org>
Hi Jean-Christophe,
Le Fri, 6 Jul 2012 14:17:19 +0200,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> > + u8 buf_in[ATMEL_AES_DMA_THRESHOLD] __aligned(sizeof(u32));
> can you allocate it
> > + int dma_in;
> > + struct atmel_aes_dma dma_lch_in;
> > +
> > + u8 buf_out[ATMEL_AES_DMA_THRESHOLD] __aligned(sizeof(u32));
> ditto
>
Why is that preferred to allocate dynamicaly these buffers (we are
talking of 2 x 16 bytes buffers) ?
> otherwise looks good
>
thanks
Eric
WARNING: multiple messages have this Message-ID (diff)
From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] crypto: add Atmel AES driver
Date: Fri, 6 Jul 2012 15:25:21 +0200 [thread overview]
Message-ID: <20120706152521.5145f1aa@eb-e6520> (raw)
In-Reply-To: <20120706121719.GD4450@game.jcrosoft.org>
Hi Jean-Christophe,
Le Fri, 6 Jul 2012 14:17:19 +0200,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a ?crit :
> > + u8 buf_in[ATMEL_AES_DMA_THRESHOLD] __aligned(sizeof(u32));
> can you allocate it
> > + int dma_in;
> > + struct atmel_aes_dma dma_lch_in;
> > +
> > + u8 buf_out[ATMEL_AES_DMA_THRESHOLD] __aligned(sizeof(u32));
> ditto
>
Why is that preferred to allocate dynamicaly these buffers (we are
talking of 2 x 16 bytes buffers) ?
> otherwise looks good
>
thanks
Eric
WARNING: multiple messages have this Message-ID (diff)
From: "Eric Bénard" <eric@eukrea.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: linux-kernel@vger.kernel.org, nicolas.ferre@atmel.com,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, herbert@gondor.hengli.com.au,
davem@davemloft.net, nicolas@eukrea.com
Subject: Re: [PATCH 2/5] crypto: add Atmel AES driver
Date: Fri, 6 Jul 2012 15:25:21 +0200 [thread overview]
Message-ID: <20120706152521.5145f1aa@eb-e6520> (raw)
In-Reply-To: <20120706121719.GD4450@game.jcrosoft.org>
Hi Jean-Christophe,
Le Fri, 6 Jul 2012 14:17:19 +0200,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> > + u8 buf_in[ATMEL_AES_DMA_THRESHOLD] __aligned(sizeof(u32));
> can you allocate it
> > + int dma_in;
> > + struct atmel_aes_dma dma_lch_in;
> > +
> > + u8 buf_out[ATMEL_AES_DMA_THRESHOLD] __aligned(sizeof(u32));
> ditto
>
Why is that preferred to allocate dynamicaly these buffers (we are
talking of 2 x 16 bytes buffers) ?
> otherwise looks good
>
thanks
Eric
next prev parent reply other threads:[~2012-07-06 13:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 17:19 [PATCH 0/5] AT91SAM9G46/M11: add crypto drivers Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-01 17:19 ` [PATCH 1/5] ARM: AT91SAM9G45: add crypto peripherals Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-01 17:19 ` [PATCH 2/5] crypto: add Atmel AES driver Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-06 12:17 ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-06 12:17 ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-06 12:17 ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-06 13:25 ` Eric Bénard [this message]
2012-07-06 13:25 ` Eric Bénard
2012-07-06 13:25 ` Eric Bénard
2012-07-01 17:19 ` [PATCH 3/5] crypto: add Atmel DES/TDES driver Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-01 17:19 ` [PATCH 4/5] crypto: add Atmel SHA1/SHA256 driver Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-01 17:19 ` [PATCH 5/5] crypto: add new tests to tcrypt Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-01 17:19 ` Eric Bénard
2012-07-11 3:25 ` [PATCH 0/5] AT91SAM9G46/M11: add crypto drivers Herbert Xu
2012-07-11 3:25 ` Herbert Xu
2012-07-11 3:25 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706152521.5145f1aa@eb-e6520 \
--to=eric@eukrea.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=nicolas@eukrea.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.