All of lore.kernel.org
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c
Date: Mon, 9 Jul 2012 09:28:09 +0200	[thread overview]
Message-ID: <20120709072809.GP30009@pengutronix.de> (raw)
In-Reply-To: <1341572162-29126-1-git-send-email-javier.martin@vista-silicon.com>

On Fri, Jul 06, 2012 at 12:56:02PM +0200, Javier Martin wrote:
> This driver wasn't converted to the new clock changes
> (clk_prepare_enable/clk_disable_unprepare). Also naming
> of emma-prp related clocks for the i.MX27 was not correct.
> ---
> Enable clocks only for i.MX27.
> 

Indeed,

>  
> -	pcdev->clk_csi = clk_get(&pdev->dev, NULL);
> -	if (IS_ERR(pcdev->clk_csi)) {
> -		dev_err(&pdev->dev, "Could not get csi clock\n");
> -		err = PTR_ERR(pcdev->clk_csi);
> -		goto exit_kfree;
> +	if (cpu_is_mx27()) {
> +		pcdev->clk_csi = devm_clk_get(&pdev->dev, "ahb");
> +		if (IS_ERR(pcdev->clk_csi)) {
> +			dev_err(&pdev->dev, "Could not get csi clock\n");
> +			err = PTR_ERR(pcdev->clk_csi);
> +			goto exit_kfree;
> +		}

but why? Now the i.MX25 won't get a clock anymore.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Javier Martin <javier.martin@vista-silicon.com>
Cc: linux-media@vger.kernel.org, fabio.estevam@freescale.com,
	linux-arm-kernel@lists.infradead.org,
	laurent.pinchart@ideasonboard.com, g.liakhovetski@gmx.de,
	mchehab@infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c
Date: Mon, 9 Jul 2012 09:28:09 +0200	[thread overview]
Message-ID: <20120709072809.GP30009@pengutronix.de> (raw)
In-Reply-To: <1341572162-29126-1-git-send-email-javier.martin@vista-silicon.com>

On Fri, Jul 06, 2012 at 12:56:02PM +0200, Javier Martin wrote:
> This driver wasn't converted to the new clock changes
> (clk_prepare_enable/clk_disable_unprepare). Also naming
> of emma-prp related clocks for the i.MX27 was not correct.
> ---
> Enable clocks only for i.MX27.
> 

Indeed,

>  
> -	pcdev->clk_csi = clk_get(&pdev->dev, NULL);
> -	if (IS_ERR(pcdev->clk_csi)) {
> -		dev_err(&pdev->dev, "Could not get csi clock\n");
> -		err = PTR_ERR(pcdev->clk_csi);
> -		goto exit_kfree;
> +	if (cpu_is_mx27()) {
> +		pcdev->clk_csi = devm_clk_get(&pdev->dev, "ahb");
> +		if (IS_ERR(pcdev->clk_csi)) {
> +			dev_err(&pdev->dev, "Could not get csi clock\n");
> +			err = PTR_ERR(pcdev->clk_csi);
> +			goto exit_kfree;
> +		}

but why? Now the i.MX25 won't get a clock anymore.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-07-09  7:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-06 10:56 [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c Javier Martin
2012-07-06 10:56 ` Javier Martin
2012-07-09  7:28 ` Sascha Hauer [this message]
2012-07-09  7:28   ` Sascha Hauer
2012-07-09  7:37   ` javier Martin
2012-07-09  7:37     ` javier Martin
2012-07-09  7:43     ` Sascha Hauer
2012-07-09  7:43       ` Sascha Hauer
2012-07-09  7:46       ` javier Martin
2012-07-09  7:46         ` javier Martin
2012-07-09  7:52         ` Baruch Siach
2012-07-09  7:52           ` Baruch Siach
2012-07-09  8:07         ` Sascha Hauer
2012-07-09  8:07           ` Sascha Hauer
2012-07-09  8:22           ` javier Martin
2012-07-09  8:22             ` javier Martin
2012-07-20 11:19             ` Guennadi Liakhovetski
2012-07-20 11:19               ` Guennadi Liakhovetski
2012-07-20 13:04               ` javier Martin
2012-07-20 13:04                 ` javier Martin
2012-07-20 13:43                 ` Guennadi Liakhovetski
2012-07-20 13:43                   ` Guennadi Liakhovetski
2012-07-23  8:15                   ` javier Martin
2012-07-23  8:15                     ` javier Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120709072809.GP30009@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.