From: Andrew Morton <akpm@linux-foundation.org>
To: JoonSoo Kim <js1304@gmail.com>
Cc: David Rientjes <rientjes@google.com>,
Mel Gorman <mgorman@suse.de>, Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: don't invoke __alloc_pages_direct_compact when order 0
Date: Mon, 9 Jul 2012 15:41:00 -0700 [thread overview]
Message-ID: <20120709154100.6a7377e6.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAAmzW4P=Qf1u6spPZCN7o3TRqvwF-rZkZA3eFtAcnCdFg2CDBg@mail.gmail.com>
On Mon, 9 Jul 2012 23:13:50 +0900
JoonSoo Kim <js1304@gmail.com> wrote:
> >> In my kernel image, __alloc_pages_direct_compact() is not inlined by gcc.
My gcc-4.4.4 doesn't inline it either.
> I think __alloc_pages_direct_compact() can't be inlined by gcc,
> because it is so big and is invoked two times in __alloc_pages_nodemask().
This. Large function, two callsites.
Making __alloc_pages_direct_compact() __always_inline adds only 26
bytes to my page_alloc.o's .text. Such is the suckiness of passing
eleven arguments!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: JoonSoo Kim <js1304@gmail.com>
Cc: David Rientjes <rientjes@google.com>,
Mel Gorman <mgorman@suse.de>, Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: don't invoke __alloc_pages_direct_compact when order 0
Date: Mon, 9 Jul 2012 15:41:00 -0700 [thread overview]
Message-ID: <20120709154100.6a7377e6.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAAmzW4P=Qf1u6spPZCN7o3TRqvwF-rZkZA3eFtAcnCdFg2CDBg@mail.gmail.com>
On Mon, 9 Jul 2012 23:13:50 +0900
JoonSoo Kim <js1304@gmail.com> wrote:
> >> In my kernel image, __alloc_pages_direct_compact() is not inlined by gcc.
My gcc-4.4.4 doesn't inline it either.
> I think __alloc_pages_direct_compact() can't be inlined by gcc,
> because it is so big and is invoked two times in __alloc_pages_nodemask().
This. Large function, two callsites.
Making __alloc_pages_direct_compact() __always_inline adds only 26
bytes to my page_alloc.o's .text. Such is the suckiness of passing
eleven arguments!
next prev parent reply other threads:[~2012-07-09 22:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 15:28 [PATCH] mm: don't invoke __alloc_pages_direct_compact when order 0 Joonsoo Kim
2012-07-06 15:28 ` Joonsoo Kim
2012-07-06 15:59 ` Minchan Kim
2012-07-06 15:59 ` Minchan Kim
2012-07-06 16:58 ` JoonSoo Kim
2012-07-06 16:58 ` JoonSoo Kim
2012-07-07 0:38 ` Minchan Kim
2012-07-07 0:38 ` Minchan Kim
2012-07-08 2:29 ` JoonSoo Kim
2012-07-08 2:29 ` JoonSoo Kim
2012-07-07 8:40 ` David Rientjes
2012-07-07 8:40 ` David Rientjes
2012-07-08 2:33 ` JoonSoo Kim
2012-07-08 2:33 ` JoonSoo Kim
2012-07-08 22:53 ` David Rientjes
2012-07-08 22:53 ` David Rientjes
2012-07-09 14:13 ` JoonSoo Kim
2012-07-09 14:13 ` JoonSoo Kim
2012-07-09 21:10 ` David Rientjes
2012-07-09 21:10 ` David Rientjes
2012-07-09 22:41 ` Andrew Morton [this message]
2012-07-09 22:41 ` Andrew Morton
2012-07-10 10:47 ` Mel Gorman
2012-07-10 10:47 ` Mel Gorman
2012-07-10 15:24 ` JoonSoo Kim
2012-07-10 15:24 ` JoonSoo Kim
2012-07-10 15:48 ` Mel Gorman
2012-07-10 15:48 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709154100.6a7377e6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.