From: wfg@linux.intel.com
To: Theodore Ts'o <tytso@mit.edu>
Cc: kernel-janitors@vger.kernel.org,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: [ext4:master 4/4] fs/ext4/resize.c:1200:9: warning: unused variable 'ret'
Date: Mon, 09 Jul 2012 23:44:04 +0000 [thread overview]
Message-ID: <20120709234404.GA5584@localhost> (raw)
Hi Theodore,
There are new compile warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git master
head: 952fc18ef9ec707ebdc16c0786ec360295e5ff15
commit: 952fc18ef9ec707ebdc16c0786ec360295e5ff15 [4/4] ext4: fix overhead calculation used by ext4_statfs()
All warnings:
fs/ext4/resize.c: In function 'ext4_update_super':
fs/ext4/resize.c:1200:9: warning: unused variable 'ret' [-Wunused-variable]
vim +1200 fs/ext4/resize.c
1197 struct ext4_new_group_data *group_data = flex_gd->groups;
1198 struct ext4_sb_info *sbi = EXT4_SB(sb);
1199 struct ext4_super_block *es = sbi->s_es;
> 1200 int i, ret;
1201
1202 BUG_ON(flex_gd->count = 0 || group_data = NULL);
1203 /*
The unused 'ret' is introduced by:
@@ -1197,7 +1197,7 @@ static void ext4_update_super(struct super_block *sb,
struct ext4_new_group_data *group_data = flex_gd->groups;
struct ext4_sb_info *sbi = EXT4_SB(sb);
struct ext4_super_block *es = sbi->s_es;
- int i;
+ int i, ret;
BUG_ON(flex_gd->count = 0 || group_data = NULL);
/*
@@ -1272,6 +1272,11 @@ static void ext4_update_super(struct super_block *sb,
&sbi->s_flex_groups[flex_group].free_inodes);
}
+ /*
+ * Update the fs overhead information
+ */
+ ext4_calculate_overhead(sb);
+
if (test_opt(sb, DEBUG))
printk(KERN_DEBUG "EXT4-fs: added group %u:"
"%llu blocks(%llu free %llu reserved)\n", flex_gd->count,
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com> Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: wfg@linux.intel.com
To: Theodore Ts'o <tytso@mit.edu>
Cc: kernel-janitors@vger.kernel.org,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: [ext4:master 4/4] fs/ext4/resize.c:1200:9: warning: unused variable 'ret'
Date: Tue, 10 Jul 2012 07:44:04 +0800 [thread overview]
Message-ID: <20120709234404.GA5584@localhost> (raw)
Hi Theodore,
There are new compile warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git master
head: 952fc18ef9ec707ebdc16c0786ec360295e5ff15
commit: 952fc18ef9ec707ebdc16c0786ec360295e5ff15 [4/4] ext4: fix overhead calculation used by ext4_statfs()
All warnings:
fs/ext4/resize.c: In function 'ext4_update_super':
fs/ext4/resize.c:1200:9: warning: unused variable 'ret' [-Wunused-variable]
vim +1200 fs/ext4/resize.c
1197 struct ext4_new_group_data *group_data = flex_gd->groups;
1198 struct ext4_sb_info *sbi = EXT4_SB(sb);
1199 struct ext4_super_block *es = sbi->s_es;
> 1200 int i, ret;
1201
1202 BUG_ON(flex_gd->count == 0 || group_data == NULL);
1203 /*
The unused 'ret' is introduced by:
@@ -1197,7 +1197,7 @@ static void ext4_update_super(struct super_block *sb,
struct ext4_new_group_data *group_data = flex_gd->groups;
struct ext4_sb_info *sbi = EXT4_SB(sb);
struct ext4_super_block *es = sbi->s_es;
- int i;
+ int i, ret;
BUG_ON(flex_gd->count == 0 || group_data == NULL);
/*
@@ -1272,6 +1272,11 @@ static void ext4_update_super(struct super_block *sb,
&sbi->s_flex_groups[flex_group].free_inodes);
}
+ /*
+ * Update the fs overhead information
+ */
+ ext4_calculate_overhead(sb);
+
if (test_opt(sb, DEBUG))
printk(KERN_DEBUG "EXT4-fs: added group %u:"
"%llu blocks(%llu free %llu reserved)\n", flex_gd->count,
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com> Intel Corporation
next reply other threads:[~2012-07-09 23:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 23:44 wfg [this message]
2012-07-09 23:44 ` [ext4:master 4/4] fs/ext4/resize.c:1200:9: warning: unused variable 'ret' wfg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709234404.GA5584@localhost \
--to=wfg@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.