All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH] IIO: Add basic MXS LRADC driver
Date: Tue, 10 Jul 2012 12:45:22 +0200	[thread overview]
Message-ID: <201207101245.23047.marex@denx.de> (raw)
In-Reply-To: <201207101241.24151.jbe@pengutronix.de>

Dear Juergen Beisert,

[...]

> > >> But wait, you're getting interrupts on channel 0. Doesn't seem quite
> > >> right. Did you happen to poke into the code and see where the issue
> > >> might be?
> > > 
> > > No yet. But if you think this is not the intended behaviour of your
> > > driver I will do a deeper look.
> > 
> > I don't know the hardware, but from what I've seen in the driver this
> > behavior looks correct. When reading a physical channel the channel will
> > be mapped to the first free virtual channel, afterward it is unmapped
> > again.
> 
> Makes sense.
> 
> > So if you are only reading a single channel it will always be mapped to
> > first virtual channel. If you'd be using buffered mode and read multiple
> > channels at once you'll probably get multiple interrupts on different
> > virtual channels.
> 
> So, the driver's behaviour is intended. Sorry for the noise.

Heh, my own driver confused me. I really better get back to this thing, I even 
have the touchscreen part in the works. Sorry for the confusion.

> Regards,
> Juergen

Best regards,
Marek Vasut

WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] IIO: Add basic MXS LRADC driver
Date: Tue, 10 Jul 2012 12:45:22 +0200	[thread overview]
Message-ID: <201207101245.23047.marex@denx.de> (raw)
In-Reply-To: <201207101241.24151.jbe@pengutronix.de>

Dear Juergen Beisert,

[...]

> > >> But wait, you're getting interrupts on channel 0. Doesn't seem quite
> > >> right. Did you happen to poke into the code and see where the issue
> > >> might be?
> > > 
> > > No yet. But if you think this is not the intended behaviour of your
> > > driver I will do a deeper look.
> > 
> > I don't know the hardware, but from what I've seen in the driver this
> > behavior looks correct. When reading a physical channel the channel will
> > be mapped to the first free virtual channel, afterward it is unmapped
> > again.
> 
> Makes sense.
> 
> > So if you are only reading a single channel it will always be mapped to
> > first virtual channel. If you'd be using buffered mode and read multiple
> > channels at once you'll probably get multiple interrupts on different
> > virtual channels.
> 
> So, the driver's behaviour is intended. Sorry for the noise.

Heh, my own driver confused me. I really better get back to this thing, I even 
have the touchscreen part in the works. Sorry for the confusion.

> Regards,
> Juergen

Best regards,
Marek Vasut

  reply	other threads:[~2012-07-10 10:45 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04  2:15 [PATCH] IIO: Add basic MXS LRADC driver Marek Vasut
2012-07-04  2:15 ` Marek Vasut
2012-07-04  4:30 ` Wolfgang Denk
2012-07-04  4:30   ` Wolfgang Denk
2012-07-04  8:35 ` Lars-Peter Clausen
2012-07-04  8:35   ` Lars-Peter Clausen
2012-07-04 23:48   ` Marek Vasut
2012-07-04 23:48     ` Marek Vasut
2012-07-05  8:33     ` Lars-Peter Clausen
2012-07-05  8:33       ` Lars-Peter Clausen
2012-07-05 19:53       ` Marek Vasut
2012-07-05 19:53         ` Marek Vasut
2012-07-19 14:23       ` Marek Vasut
2012-07-19 14:23         ` Marek Vasut
2012-07-19 14:33         ` Lars-Peter Clausen
2012-07-19 14:33           ` Lars-Peter Clausen
2012-07-19 15:15           ` Marek Vasut
2012-07-19 15:15             ` Marek Vasut
2012-07-19 19:26           ` Marek Vasut
2012-07-19 19:26             ` Marek Vasut
2012-07-20  2:18             ` Marek Vasut
2012-07-20  2:18               ` Marek Vasut
2012-07-20  8:39               ` Robert Schwebel
2012-07-20  8:39                 ` Robert Schwebel
2012-07-20 11:32                 ` Marek Vasut
2012-07-20 11:32                   ` Marek Vasut
2012-07-20 14:09               ` Lars-Peter Clausen
2012-07-20 14:09                 ` Lars-Peter Clausen
2012-07-22 19:48                 ` Jonathan Cameron
2012-07-20 14:11             ` Lars-Peter Clausen
2012-07-20 14:11               ` Lars-Peter Clausen
2012-07-20 15:12               ` Marek Vasut
2012-07-20 15:12                 ` Marek Vasut
2012-07-09  9:19 ` Juergen Beisert
2012-07-09  9:19   ` Juergen Beisert
2012-07-09  9:52   ` Lars-Peter Clausen
2012-07-09  9:52     ` Lars-Peter Clausen
2012-07-09 10:03   ` Marek Vasut
2012-07-09 10:03     ` Marek Vasut
2012-07-10  9:20     ` Juergen Beisert
2012-07-10  9:20       ` Juergen Beisert
2012-07-10  9:26       ` Marek Vasut
2012-07-10  9:26         ` Marek Vasut
2012-07-10  9:49         ` Juergen Beisert
2012-07-10  9:49           ` Juergen Beisert
2012-07-10 10:08           ` Marek Vasut
2012-07-10 10:08             ` Marek Vasut
2012-07-10 10:26             ` Juergen Beisert
2012-07-10 10:26               ` Juergen Beisert
2012-07-10 10:35               ` Lars-Peter Clausen
2012-07-10 10:35                 ` Lars-Peter Clausen
2012-07-10 10:41                 ` Juergen Beisert
2012-07-10 10:41                   ` Juergen Beisert
2012-07-10 10:45                   ` Marek Vasut [this message]
2012-07-10 10:45                     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207101245.23047.marex@denx.de \
    --to=marex@denx.de \
    --cc=jbe@pengutronix.de \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.