From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change
Date: Tue, 10 Jul 2012 13:38:58 +0200 [thread overview]
Message-ID: <201207101338.58340.marex@denx.de> (raw)
In-Reply-To: <20120710112050.GH26888@b20223-02.ap.freescale.net>
Dear Richard Zhao,
[...]
> > > --- a/drivers/usb/core/hub.c
> > > +++ b/drivers/usb/core/hub.c
> > > @@ -1924,6 +1924,11 @@ void usb_disconnect(struct usb_device **pdev)
> > >
> > > */
> > >
> > > device_del(&udev->dev);
> > >
> > > + if (udev->parent && !udev->parent->parent) {
> > > + struct usb_hcd *hcd = bus_to_hcd(udev->bus);
> > > + usb_phy_notify_disconnect(hcd->phy, udev->portnum);
> > > + }
> >
> > Shouldn't that go before device_del() ?
>
> Any difference?
I was worried some corruption of other members in udev structure might happen,
but I'm not so sure anymore after taking deer look.
> Thanks
> Richard
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Richard Zhao <richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
B29397-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
B20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change
Date: Tue, 10 Jul 2012 13:38:58 +0200 [thread overview]
Message-ID: <201207101338.58340.marex@denx.de> (raw)
In-Reply-To: <20120710112050.GH26888-iWYTGMXpHj9ITqJhDdzsOjpauB2SiJktrE5yTffgRl4@public.gmane.org>
Dear Richard Zhao,
[...]
> > > --- a/drivers/usb/core/hub.c
> > > +++ b/drivers/usb/core/hub.c
> > > @@ -1924,6 +1924,11 @@ void usb_disconnect(struct usb_device **pdev)
> > >
> > > */
> > >
> > > device_del(&udev->dev);
> > >
> > > + if (udev->parent && !udev->parent->parent) {
> > > + struct usb_hcd *hcd = bus_to_hcd(udev->bus);
> > > + usb_phy_notify_disconnect(hcd->phy, udev->portnum);
> > > + }
> >
> > Shouldn't that go before device_del() ?
>
> Any difference?
I was worried some corruption of other members in udev structure might happen,
but I'm not so sure anymore after taking deer look.
> Thanks
> Richard
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-07-10 11:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-07 14:56 [PATCH v9 REBASE 0/9] add imx usb driver based on Greg next tree Richard Zhao
2012-07-07 14:56 ` Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 1/9] USB: Chipidea: rename struct ci13xxx variables from udc to ci Richard Zhao
2012-07-07 14:56 ` Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 2/9] USB: Chipidea: add unified ci13xxx_{add, remove}_device for platform drivers Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 2/9] USB: Chipidea: add unified ci13xxx_{add,remove}_device " Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 3/9] USB: Chipidea: add ci13xxx device id management Richard Zhao
2012-07-07 14:56 ` Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 4/9] usb: chipidea: select USB_EHCI_ROOT_HUB_TT in USB_CHIPIDEA_HOST of Kconfig Richard Zhao
2012-07-07 14:56 ` Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 5/9] usb: otg: add notify_connect/notify_disconnect callback Richard Zhao
2012-07-07 14:56 ` Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change Richard Zhao
2012-07-07 14:56 ` Richard Zhao
2012-07-09 16:57 ` Greg KH
2012-07-09 16:57 ` Greg KH
2012-07-10 1:44 ` Richard Zhao
2012-07-10 1:44 ` Richard Zhao
2012-07-10 14:24 ` Alan Stern
2012-07-10 14:24 ` Alan Stern
2012-07-10 14:53 ` Richard Zhao
2012-07-10 14:53 ` Richard Zhao
2012-07-10 3:14 ` Richard Zhao
2012-07-10 3:14 ` Richard Zhao
2012-07-10 3:22 ` Marek Vasut
2012-07-10 3:22 ` Marek Vasut
2012-07-10 11:20 ` Richard Zhao
2012-07-10 11:20 ` Richard Zhao
2012-07-10 11:38 ` Marek Vasut [this message]
2012-07-10 11:38 ` Marek Vasut
2012-07-10 15:07 ` Alan Stern
2012-07-10 15:07 ` Alan Stern
2012-07-11 2:53 ` Richard Zhao
2012-07-11 2:53 ` Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 7/9] usb: chipidea: permit driver bindings pass phy pointer Richard Zhao
2012-07-07 14:56 ` Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 8/9] usb: otg: add basic mxs phy driver support Richard Zhao
2012-07-07 14:56 ` Richard Zhao
2012-07-07 14:56 ` [PATCH v9 REBASE 9/9] usb: chipidea: add imx platform driver Richard Zhao
2012-07-07 14:56 ` Richard Zhao
2012-07-09 17:02 ` [PATCH v9 REBASE 0/9] add imx usb driver based on Greg next tree Greg KH
2012-07-09 17:02 ` Greg KH
2012-07-10 1:52 ` Marek Vasut
2012-07-10 1:52 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207101338.58340.marex@denx.de \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.