From: Marek Vasut <marex@denx.de>
To: Lauri Hintsala <lauri.hintsala@bluegiga.com>
Cc: Shawn Guo <shawn.guo@linaro.org>,
Wolfram Sang <w.sang@pengutronix.de>,
Koen Beel <koen.beel@barco.com>,
linux-mmc@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Veli-Pekka Peltola <veli-pekka.peltola@bluegiga.com>
Subject: Re: mmc: mxs: DEADLOCK
Date: Tue, 10 Jul 2012 17:02:52 +0200 [thread overview]
Message-ID: <201207101702.52632.marex@denx.de> (raw)
In-Reply-To: <4FFC367A.8020100@bluegiga.com>
Dear Lauri Hintsala,
[...]
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -278,11 +278,11 @@ static irqreturn_t mxs_mmc_irq_handler(int irq,
> void *dev_id)
> writel(stat & MXS_MMC_IRQ_BITS,
> host->base + HW_SSP_CTRL1(host) + STMP_OFFSET_REG_CLR);
>
> + spin_unlock(&host->lock);
> +
> if ((stat & BM_SSP_CTRL1_SDIO_IRQ) && (stat & BM_SSP_CTRL1_SDIO_IRQ_EN))
> mmc_signal_sdio_irq(host->mmc);
>
> - spin_unlock(&host->lock);
> -
Spinlock in irq handler is interesting too ;-)
> if (stat & BM_SSP_CTRL1_RESP_TIMEOUT_IRQ)
> cmd->error = -ETIMEDOUT;
> else if (stat & BM_SSP_CTRL1_RESP_ERR_IRQ)
>
>
> Is there any reason to keep mmc_signal_sdio_irq inside the spinlock?
> mmc_signal_sdio_irq calls mxs_mmc_enable_sdio_irq and it tries to
> acquire lock while it is already acquired.
>
>
> Best regards,
> Lauri Hintsala
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: mmc: mxs: DEADLOCK
Date: Tue, 10 Jul 2012 17:02:52 +0200 [thread overview]
Message-ID: <201207101702.52632.marex@denx.de> (raw)
In-Reply-To: <4FFC367A.8020100@bluegiga.com>
Dear Lauri Hintsala,
[...]
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -278,11 +278,11 @@ static irqreturn_t mxs_mmc_irq_handler(int irq,
> void *dev_id)
> writel(stat & MXS_MMC_IRQ_BITS,
> host->base + HW_SSP_CTRL1(host) + STMP_OFFSET_REG_CLR);
>
> + spin_unlock(&host->lock);
> +
> if ((stat & BM_SSP_CTRL1_SDIO_IRQ) && (stat & BM_SSP_CTRL1_SDIO_IRQ_EN))
> mmc_signal_sdio_irq(host->mmc);
>
> - spin_unlock(&host->lock);
> -
Spinlock in irq handler is interesting too ;-)
> if (stat & BM_SSP_CTRL1_RESP_TIMEOUT_IRQ)
> cmd->error = -ETIMEDOUT;
> else if (stat & BM_SSP_CTRL1_RESP_ERR_IRQ)
>
>
> Is there any reason to keep mmc_signal_sdio_irq inside the spinlock?
> mmc_signal_sdio_irq calls mxs_mmc_enable_sdio_irq and it tries to
> acquire lock while it is already acquired.
>
>
> Best regards,
> Lauri Hintsala
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-10 15:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 14:04 mmc: mxs: DEADLOCK Lauri Hintsala
2012-07-10 14:04 ` Lauri Hintsala
2012-07-10 15:02 ` Marek Vasut [this message]
2012-07-10 15:02 ` Marek Vasut
2012-07-11 6:10 ` Shawn Guo
2012-07-11 6:10 ` Shawn Guo
2012-07-11 6:06 ` Shawn Guo
2012-07-11 6:06 ` Shawn Guo
2012-07-11 6:08 ` Lauri Hintsala
2012-07-11 6:08 ` Lauri Hintsala
2012-07-12 14:00 ` Attila Kinali
2012-07-12 14:00 ` Attila Kinali
2012-07-12 14:39 ` Shawn Guo
2012-07-12 14:39 ` Shawn Guo
2012-07-12 15:13 ` Attila Kinali
2012-07-12 15:13 ` Attila Kinali
2012-07-16 5:57 ` Lauri Hintsala
2012-07-16 5:57 ` Lauri Hintsala
2012-07-16 12:07 ` Attila Kinali
2012-07-16 12:07 ` Attila Kinali
2012-07-17 4:54 ` Lauri Hintsala
2012-07-17 4:54 ` Lauri Hintsala
2012-07-17 12:40 ` Shawn Guo
2012-07-17 12:40 ` Shawn Guo
2012-07-17 13:03 ` Lauri Hintsala
2012-07-17 13:03 ` Lauri Hintsala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207101702.52632.marex@denx.de \
--to=marex@denx.de \
--cc=koen.beel@barco.com \
--cc=lauri.hintsala@bluegiga.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=veli-pekka.peltola@bluegiga.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.