Re: [PATCH 2/7] fsfreeze: emergency thaw will deadlock on s_umount

[Jan Kara <jack@suse.cz>]

  Hello,

On Wed 11-07-12 11:38:21, Fernando Luis Vazquez Cao wrote:
> On 2012/07/10 21:15, Jan Kara wrote:
> 
> >On Tue 10-07-12 18:30:27, Fernando Luis Vazquez Cao wrote:
> >>Ok. I would appreciate if you could take a look at all the patches.
> >   Except for patches 1 and 2 I'm basically OK with the series.
> 
> Thank you for reviewing the patches.
  You are welcome.

> Hopefully my reply to your comments on patch 1 address your
> concerns.
  See my reply to patch 1...

> By the way, is there anything specific in patch 2
> (apart from the conditional locking ugliness) that you want
> to me to change? Maybe resolve the conflicts with your patch
> set?
  I would be happier if you based your patches on my patch set (less work
for me ;). OTOH your patches are simpler so Al might decide to merge them
first. So all in all my opinion doesn't matter much here. It is Al who
decides...

> >>By the way, do you want me to rebase on top of your tree?
> >   It depends on how Al plans to handle my freezing fixes. I still don't
> >see them in his tree. Al?
> 
> Ok. Could you get your Acked-by or Reviewed-by for the changes
> you agree with?
  Please fix the patch 1 and the conditional locking in patch 2 (that will
also require changes to other patches in the series - they might be smaller
if you reorder patches as I suggested). Then I'll check the whole series
and can give you my Reviewed-by.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR