All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fernando Luis Vazquez Cao <fernando_b1@lab.ntt.co.jp>
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Dave Chinner <dchinner@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/7] fsfreeze: emergency thaw will deadlock on s_umount
Date: Thu, 12 Jul 2012 11:08:25 +0900	[thread overview]
Message-ID: <4FFE3199.9080209@lab.ntt.co.jp> (raw)
In-Reply-To: <20120711090637.GD1316@quack.suse.cz>

Hi Jan,

On 2012/07/11 18:06, Jan Kara wrote:

>> By the way, is there anything specific in patch 2
>> (apart from the conditional locking ugliness) that you want
>> to me to change? Maybe resolve the conflicts with your patch
>> set?
>    I would be happier if you based your patches on my patch set (less work
> for me ;). OTOH your patches are simpler so Al might decide to merge them
> first. So all in all my opinion doesn't matter much here. It is Al who
> decides...

I will rebase against Al's vfs tree. If your patches get merged first
I do not mind resolving the merge conflicts you mentioned.

>> Ok. Could you get your Acked-by or Reviewed-by for the changes
>> you agree with?
>    Please fix the patch 1 and the conditional locking in patch 2 (that will
> also require changes to other patches in the series - they might be smaller
> if you reorder patches as I suggested). Then I'll check the whole series
> and can give you my Reviewed-by.

Ok, I will fix patch 1 and 2 (probably without reordering) and repost.

Thank you again for your comments!

Regards,
Fernando


  reply	other threads:[~2012-07-12  2:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10  8:16 [RFC, PATCH 0/7] fsfreeze: miscellaneous fixes and cleanups Fernando Luis Vázquez Cao
2012-07-10  8:20 ` [PATCH 1/7] fsfreeze: Prevent emergency thaw from looping infinitely Fernando Luis Vázquez Cao
2012-07-10 12:08   ` Jan Kara
2012-07-11  2:25     ` Fernando Luis Vazquez Cao
2012-07-11  9:02       ` Jan Kara
2012-07-12  1:49         ` Fernando Luis Vazquez Cao
2012-07-10  8:23 ` [PATCH 2/7] fsfreeze: emergency thaw will deadlock on s_umount Fernando Luis Vázquez Cao
2012-07-10  9:09   ` Jan Kara
2012-07-10  9:13     ` Jan Kara
2012-07-10  9:30       ` Fernando Luis Vazquez Cao
2012-07-10 12:15         ` Jan Kara
2012-07-11  2:38           ` Fernando Luis Vazquez Cao
2012-07-11  9:06             ` Jan Kara
2012-07-12  2:08               ` Fernando Luis Vazquez Cao [this message]
2012-07-10  8:25 ` [PATCH 3/7] fsfreeze: freeze_super and thaw_bdev don't play well together Fernando Luis Vázquez Cao
2012-07-10  8:30 ` [PATCH 4/7] fsfreeze: switch to using super methods where possible Fernando Luis Vázquez Cao
2012-07-10  8:32 ` [PATCH 5/7] fsfreeze: move emergency thaw code to fs/super.c Fernando Luis Vázquez Cao
2012-07-10  8:34 ` [PATCH 6/7] fsfreeze: add vfs ioctl to check freeze state Fernando Luis Vázquez Cao
2012-07-10  8:35 ` [PATCH 7/7] fsfreeze: add block device " Fernando Luis Vázquez Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFE3199.9080209@lab.ntt.co.jp \
    --to=fernando_b1@lab.ntt.co.jp \
    --cc=dchinner@redhat.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.