From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: spi-devel-general@lists.sourceforge.net,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rob.herring@calxeda.com,
grant.likely@secretlab.ca, kgene.kim@samsung.com,
jaswinder.singh@linaro.org
Subject: Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data
Date: Wed, 11 Jul 2012 12:47:17 +0100 [thread overview]
Message-ID: <20120711114716.GF3938@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1342005359-748-1-git-send-email-thomas.abraham@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
On Wed, Jul 11, 2012 at 04:45:59PM +0530, Thomas Abraham wrote:
> The set_level callback in the controller data, which is used to configure
> the slave select line, cannot be supported when migrating the driver to
> device tree based discovery. Since all the platforms currently use gpio
> as the slave select line, this callback can be removed from the
> controller data and replaced with call to gpio_set_value in the driver.
I don't seem to have patches 1-4?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data
Date: Wed, 11 Jul 2012 12:47:17 +0100 [thread overview]
Message-ID: <20120711114716.GF3938@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1342005359-748-1-git-send-email-thomas.abraham@linaro.org>
On Wed, Jul 11, 2012 at 04:45:59PM +0530, Thomas Abraham wrote:
> The set_level callback in the controller data, which is used to configure
> the slave select line, cannot be supported when migrating the driver to
> device tree based discovery. Since all the platforms currently use gpio
> as the slave select line, this callback can be removed from the
> controller data and replaced with call to gpio_set_value in the driver.
I don't seem to have patches 1-4?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120711/418f6cca/attachment.sig>
next prev parent reply other threads:[~2012-07-11 11:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 14:27 [PATCH v4 0/6] spi: s3c64xx: add support for device tree Thomas Abraham
2012-07-10 14:27 ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro Thomas Abraham
2012-07-10 14:27 ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 2/6] spi: s3c64xx: move controller information into driver data Thomas Abraham
2012-07-10 14:27 ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 3/6] ARM: Samsung: Remove pdev pointer parameter from spi gpio setup functions Thomas Abraham
2012-07-10 14:27 ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function Thomas Abraham
2012-07-10 14:27 ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data Thomas Abraham
2012-07-10 14:27 ` Thomas Abraham
[not found] ` <1341930459-25223-6-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-07-10 14:38 ` Mark Brown
2012-07-10 14:38 ` Mark Brown
2012-07-10 16:52 ` Thomas Abraham
2012-07-10 16:52 ` Thomas Abraham
2012-07-10 16:57 ` Mark Brown
2012-07-10 16:57 ` Mark Brown
2012-07-10 17:26 ` Thomas Abraham
2012-07-10 17:26 ` Thomas Abraham
2012-07-11 11:15 ` [PATCH v5 " Thomas Abraham
2012-07-11 11:15 ` Thomas Abraham
2012-07-11 11:47 ` Mark Brown [this message]
2012-07-11 11:47 ` Mark Brown
2012-07-11 12:21 ` Thomas Abraham
2012-07-11 12:21 ` Thomas Abraham
2012-07-11 13:31 ` Mark Brown
2012-07-11 13:31 ` Mark Brown
2012-07-11 15:29 ` Thomas Abraham
2012-07-11 15:29 ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 6/6] spi: s3c64xx: add device tree support Thomas Abraham
2012-07-10 14:27 ` Thomas Abraham
2012-07-11 11:17 ` [PATCH v5 " Thomas Abraham
2012-07-11 11:17 ` Thomas Abraham
-- strict thread matches above, loose matches on Subject: below --
2012-07-11 15:40 [PATCH v5 0/6] spi: s3c64xx: add support for device tree Thomas Abraham
2012-07-11 15:41 ` [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data Thomas Abraham
2012-07-11 15:41 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120711114716.GF3938@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jaswinder.singh@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.