From: Kent Yoder <key-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: "Zhang, Xiaoyan" <xiaoyan.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Cihula,
Joseph" <joseph.cihula-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Wei, Gang" <gang.wei-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
"debora-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org"
<debora-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
"srajiv-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org"
<srajiv-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
"m.selhorst-iBygD9l97zzQT0dZR+AlfA@public.gmane.org"
<m.selhorst-iBygD9l97zzQT0dZR+AlfA@public.gmane.org>,
"shpedoikal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<shpedoikal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
<james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
"hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org"
<hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
"linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V3 1/2] driver: add PPI support in tpm driver
Date: Thu, 12 Jul 2012 09:45:29 -0500 [thread overview]
Message-ID: <20120712144529.GA32640@linux.vnet.ibm.com> (raw)
In-Reply-To: <953B7F5DA8C0F44CBD2621D8763F4F600C8A32-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On Thu, Jul 12, 2012 at 02:38:56AM +0000, Zhang, Xiaoyan wrote:
> Hi Kent,
>
> Thanks for your comment on the patch. But there's some confusion on my side.
> You mentioned not to change the tpm driver name. But the driver is linked from tpm.c and tpm_ppi.c, so I should change the original tpm.c file name, right? Is it acceptable to change tpm.c to tpm_common.c or tpm_utils.c or else?
I think you can just add tpm_ppi.c like this:
diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile
index beac52f6..96b9222 100644
--- a/drivers/char/tpm/Makefile
+++ b/drivers/char/tpm/Makefile
@@ -4,7 +4,7 @@
obj-$(CONFIG_TCG_TPM) += tpm.o
ifdef CONFIG_ACPI
obj-$(CONFIG_TCG_TPM) += tpm_bios.o
- tpm_bios-objs += tpm_eventlog.o tpm_acpi.o
+ tpm_bios-objs += tpm_eventlog.o tpm_acpi.o tpm_ppi.o
endif
obj-$(CONFIG_TCG_TIS) += tpm_tis.o
obj-$(CONFIG_TCG_TIS_I2C_INFINEON) += tpm_i2c_infineon.o
Kent
>
> Thanks,
> Xiaoyan
WARNING: multiple messages have this Message-ID (diff)
From: Kent Yoder <key@linux.vnet.ibm.com>
To: "Zhang, Xiaoyan" <xiaoyan.zhang@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Cihula, Joseph" <joseph.cihula@intel.com>,
"Wei, Gang" <gang.wei@intel.com>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
"debora@linux.vnet.ibm.com" <debora@linux.vnet.ibm.com>,
"srajiv@linux.vnet.ibm.com" <srajiv@linux.vnet.ibm.com>,
"m.selhorst@sirrix.com" <m.selhorst@sirrix.com>,
"shpedoikal@gmail.com" <shpedoikal@gmail.com>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"james.l.morris@oracle.com" <james.l.morris@oracle.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
Subject: Re: [PATCH V3 1/2] driver: add PPI support in tpm driver
Date: Thu, 12 Jul 2012 09:45:29 -0500 [thread overview]
Message-ID: <20120712144529.GA32640@linux.vnet.ibm.com> (raw)
In-Reply-To: <953B7F5DA8C0F44CBD2621D8763F4F600C8A32@SHSMSX101.ccr.corp.intel.com>
On Thu, Jul 12, 2012 at 02:38:56AM +0000, Zhang, Xiaoyan wrote:
> Hi Kent,
>
> Thanks for your comment on the patch. But there's some confusion on my side.
> You mentioned not to change the tpm driver name. But the driver is linked from tpm.c and tpm_ppi.c, so I should change the original tpm.c file name, right? Is it acceptable to change tpm.c to tpm_common.c or tpm_utils.c or else?
I think you can just add tpm_ppi.c like this:
diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile
index beac52f6..96b9222 100644
--- a/drivers/char/tpm/Makefile
+++ b/drivers/char/tpm/Makefile
@@ -4,7 +4,7 @@
obj-$(CONFIG_TCG_TPM) += tpm.o
ifdef CONFIG_ACPI
obj-$(CONFIG_TCG_TPM) += tpm_bios.o
- tpm_bios-objs += tpm_eventlog.o tpm_acpi.o
+ tpm_bios-objs += tpm_eventlog.o tpm_acpi.o tpm_ppi.o
endif
obj-$(CONFIG_TCG_TIS) += tpm_tis.o
obj-$(CONFIG_TCG_TIS_I2C_INFINEON) += tpm_i2c_infineon.o
Kent
>
> Thanks,
> Xiaoyan
next prev parent reply other threads:[~2012-07-12 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 6:54 [PATCH V3 1/2] driver: add PPI support in tpm driver Zhang, Xiaoyan
2012-06-21 6:54 ` Zhang, Xiaoyan
2012-07-11 15:24 ` Kent Yoder
2012-07-11 15:24 ` Kent Yoder
[not found] ` <20120711152430.GC21153-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-07-12 2:38 ` Zhang, Xiaoyan
2012-07-12 2:38 ` Zhang, Xiaoyan
[not found] ` <953B7F5DA8C0F44CBD2621D8763F4F600C8A32-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-07-12 14:45 ` Kent Yoder [this message]
2012-07-12 14:45 ` Kent Yoder
2012-08-15 20:04 ` Kent Yoder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712144529.GA32640@linux.vnet.ibm.com \
--to=key-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=debora-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=gang.wei-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=joseph.cihula-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.selhorst-iBygD9l97zzQT0dZR+AlfA@public.gmane.org \
--cc=shpedoikal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=srajiv-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=xiaoyan.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.