All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rjw@sisk.pl, lenb@kernel.org, linux-pm@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/5] acpi : remove power from acpi_processor_cx structure
Date: Thu, 12 Jul 2012 20:17:01 -0400	[thread overview]
Message-ID: <20120713001701.GB13574@phenom.dumpdata.com> (raw)
In-Reply-To: <1342127026-1526-4-git-send-email-daniel.lezcano@linaro.org>

On Thu, Jul 12, 2012 at 11:03:45PM +0200, Daniel Lezcano wrote:
> Remove the power field as it is not used.
> 
It looks to be used in drivers/xen/xen-acpi-processor.c.

I could emulate some value and stick it in there.. but I am
more curious - what is the intent of this value?


> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  drivers/acpi/processor_idle.c |    2 --
>  include/acpi/processor.h      |    1 -
>  2 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index d044588..99ba58f 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -485,8 +485,6 @@ static int acpi_processor_get_power_info_cst(struct acpi_processor *pr)
>  		if (obj->type != ACPI_TYPE_INTEGER)
>  			continue;
>  
> -		cx.power = obj->integer.value;
> -
>  		current_count++;
>  		memcpy(&(pr->power.states[current_count]), &cx, sizeof(cx));
>  
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index 0957457..87bb9d7 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -58,7 +58,6 @@ struct acpi_processor_cx {
>  	u32 address;
>  	u8 entry_method;
>  	u32 latency;
> -	u32 power;
>  	u64 time;
>  	u8 bm_sts_skip;
>  	char desc[ACPI_CX_DESC_LEN];
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-07-13  0:25 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12 21:03 [PATCH 1/5] acpi : remove latency_ticks from acpi_processor_cx structure Daniel Lezcano
2012-07-12 21:03 ` [PATCH 2/5] acpi : remove index " Daniel Lezcano
2012-07-12 21:44   ` Rafael J. Wysocki
2012-07-12 21:57     ` Daniel Lezcano
2012-07-13 18:13       ` Rafael J. Wysocki
2012-07-17 20:32   ` Rafael J. Wysocki
2012-07-17 20:34     ` Rafael J. Wysocki
2012-07-12 21:03 ` [PATCH 3/5] acpi : remove usage " Daniel Lezcano
2012-07-12 21:45   ` Rafael J. Wysocki
2012-07-17 20:35   ` Rafael J. Wysocki
2012-07-12 21:03 ` [PATCH 4/5] acpi : remove power " Daniel Lezcano
2012-07-12 21:45   ` Rafael J. Wysocki
2012-07-13  0:17   ` Konrad Rzeszutek Wilk [this message]
2012-07-13  7:36     ` Daniel Lezcano
2012-07-13 12:23     ` Daniel Lezcano
2012-07-13 18:14       ` Rafael J. Wysocki
2012-07-16 15:23       ` Konrad Rzeszutek Wilk
2012-07-12 21:03 ` [PATCH 5/5] acpi : remove time " Daniel Lezcano
2012-07-12 21:46   ` Rafael J. Wysocki
2012-07-17 20:35   ` Rafael J. Wysocki
2012-07-12 21:40 ` [PATCH 1/5] acpi : remove latency_ticks " Rafael J. Wysocki
2012-07-17 20:32 ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2012-07-12 15:29 Daniel Lezcano
2012-07-12 15:30 ` [PATCH 4/5] acpi : remove power " Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120713001701.GB13574@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.