From: Andrew Morton <akpm@linux-foundation.org>
To: Michel Lespinasse <walken@google.com>
Cc: aarcange@redhat.com, dwmw2@infradead.org, riel@redhat.com,
peterz@infradead.org, daniel.santos@pobox.com, axboe@kernel.dk,
ebiederm@xmission.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH v2 05/12] rbtree: performance and correctness test
Date: Fri, 13 Jul 2012 13:15:14 -0700 [thread overview]
Message-ID: <20120713131514.86ab4df4.akpm@linux-foundation.org> (raw)
In-Reply-To: <1342139517-3451-6-git-send-email-walken@google.com>
On Thu, 12 Jul 2012 17:31:50 -0700
Michel Lespinasse <walken@google.com> wrote:
> This small module helps measure the performance of rbtree insert and erase.
>
> Additionally, we run a few correctness tests to check that the rbtrees have
> all desired properties:
> - contains the right number of nodes in the order desired,
> - never two consecutive red nodes on any path,
> - all paths to leaf nodes have the same number of black nodes,
> - root node is black
>
> Signed-off-by: Michel Lespinasse <walken@google.com>
> ---
> Makefile | 2 +-
> lib/Kconfig.debug | 1 +
> tests/Kconfig | 18 +++++++
> tests/Makefile | 1 +
> tests/rbtree_test.c | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++
This patch does a new thing: adds a kernel self-test module into
lib/tests/ and sets up the infrastructure to add new kernel self-test
modules in that directory.
I don't see a problem with this per-se, but it is a new thing which we
should think about.
In previous such cases (eg, kernel/rcutorture.c) we put those modules
into the same directory as the code which is being tested. So to
follow that pattern, this new code would have gone into lib/.
If we adopt your new proposal then we should perhaps also move tests
such as rcutorture over into tests/. And that makes one wonder whether
we should have a standalone directory for kernel selftest modules. eg
tests/self-test-nmodules/.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Michel Lespinasse <walken@google.com>
Cc: aarcange@redhat.com, dwmw2@infradead.org, riel@redhat.com,
peterz@infradead.org, daniel.santos@pobox.com, axboe@kernel.dk,
ebiederm@xmission.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH v2 05/12] rbtree: performance and correctness test
Date: Fri, 13 Jul 2012 13:15:14 -0700 [thread overview]
Message-ID: <20120713131514.86ab4df4.akpm@linux-foundation.org> (raw)
In-Reply-To: <1342139517-3451-6-git-send-email-walken@google.com>
On Thu, 12 Jul 2012 17:31:50 -0700
Michel Lespinasse <walken@google.com> wrote:
> This small module helps measure the performance of rbtree insert and erase.
>
> Additionally, we run a few correctness tests to check that the rbtrees have
> all desired properties:
> - contains the right number of nodes in the order desired,
> - never two consecutive red nodes on any path,
> - all paths to leaf nodes have the same number of black nodes,
> - root node is black
>
> Signed-off-by: Michel Lespinasse <walken@google.com>
> ---
> Makefile | 2 +-
> lib/Kconfig.debug | 1 +
> tests/Kconfig | 18 +++++++
> tests/Makefile | 1 +
> tests/rbtree_test.c | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++
This patch does a new thing: adds a kernel self-test module into
lib/tests/ and sets up the infrastructure to add new kernel self-test
modules in that directory.
I don't see a problem with this per-se, but it is a new thing which we
should think about.
In previous such cases (eg, kernel/rcutorture.c) we put those modules
into the same directory as the code which is being tested. So to
follow that pattern, this new code would have gone into lib/.
If we adopt your new proposal then we should perhaps also move tests
such as rcutorture over into tests/. And that makes one wonder whether
we should have a standalone directory for kernel selftest modules. eg
tests/self-test-nmodules/.
next prev parent reply other threads:[~2012-07-13 20:15 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 0:31 [PATCH v2 00/12] rbtree updates Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-07-13 0:31 ` [PATCH v2 01/12] rbtree: reference Documentation/rbtree.txt for usage instructions Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-07-13 0:31 ` [PATCH v2 02/12] rbtree: empty nodes have no color Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-07-13 0:31 ` [PATCH v2 03/12] rbtree: fix incorrect rbtree node insertion in fs/proc/proc_sysctl.c Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-07-13 0:31 ` [PATCH v2 04/12] rbtree: move some implementation details from rbtree.h to rbtree.c Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-07-13 0:31 ` [PATCH v2 05/12] rbtree: performance and correctness test Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-07-13 20:15 ` Andrew Morton [this message]
2012-07-13 20:15 ` Andrew Morton
2012-07-13 22:33 ` Michel Lespinasse
2012-07-13 22:33 ` Michel Lespinasse
2012-07-13 22:45 ` Andrew Morton
2012-07-13 22:45 ` Andrew Morton
2012-07-13 23:09 ` Michel Lespinasse
2012-07-13 23:09 ` Michel Lespinasse
2012-07-13 23:11 ` Michel Lespinasse
2012-07-13 23:11 ` Michel Lespinasse
2012-07-13 0:31 ` [PATCH v2 06/12] rbtree: break out of rb_insert_color loop after tree rotation Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-07-13 0:31 ` [PATCH v2 07/12] rbtree: adjust root color in rb_insert_color() only when necessary Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-08-31 8:01 ` Adrian Hunter
2012-08-31 8:01 ` Adrian Hunter
2012-08-31 8:07 ` Michel Lespinasse
2012-08-31 8:07 ` Michel Lespinasse
2012-08-31 8:15 ` Andrew Morton
2012-08-31 8:15 ` Andrew Morton
2012-08-31 8:35 ` Adrian Hunter
2012-08-31 8:35 ` Adrian Hunter
2012-08-31 8:39 ` Michel Lespinasse
2012-08-31 8:39 ` Michel Lespinasse
2012-09-06 20:47 ` Olof Johansson
2012-09-06 20:47 ` Olof Johansson
2012-08-31 9:25 ` Alexander Shishkin
2012-08-31 9:25 ` Alexander Shishkin
2012-09-08 1:26 ` Arnaldo Carvalho de Melo
2012-09-08 1:26 ` Arnaldo Carvalho de Melo
2012-09-08 11:49 ` [tip:perf/core] perf tools: Fix build for another rbtree.c change tip-bot for Adrian Hunter
2012-07-13 0:31 ` [PATCH v2 08/12] rbtree: low level optimizations in rb_insert_color() Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-07-13 0:31 ` [PATCH v2 09/12] rbtree: adjust node color in __rb_erase_color() only when necessary Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-07-13 0:31 ` [PATCH v2 10/12] rbtree: optimize case selection logic in __rb_erase_color() Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-07-13 0:31 ` [PATCH v2 11/12] rbtree: low level optimizations " Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
2012-07-13 0:31 ` [PATCH v2 12/12] rbtree: coding style adjustments Michel Lespinasse
2012-07-13 0:31 ` Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713131514.86ab4df4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=axboe@kernel.dk \
--cc=daniel.santos@pobox.com \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.