From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: "Kirill A. Shutemov"
<kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Dmitry V. Levin" <ldv-u2l5PoMzF/Vg9hUCZPvPmw@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
KOSAKI Motohiro
<kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] ns: move free_nsproxy() out of do_exit() path
Date: Fri, 13 Jul 2012 14:08:06 -0700 [thread overview]
Message-ID: <20120713140806.b3d0fda8.akpm@linux-foundation.org> (raw)
In-Reply-To: <1342180088-22647-1-git-send-email-kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On Fri, 13 Jul 2012 14:48:08 +0300
"Kirill A. Shutemov" <kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote:
> From: "Kirill A. Shutemov" <kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>
> free_nsproxy() is too heavy to be on exit path. Let's free namespaces
> asynchronously to not block exit_group() syscall.
Please be specific, and complete.
Why is it "too heavy"? Where is the time being spent? Is it spent in
D state or is it spent burning CPU cycles? Does the patch simply
offload the work into kernel threads, providing no net gain?
> The patch also fixes bug with free namespace without synchronize_rcu() through
> put_nsproxy().
I just don't understand this description. Please send a new one which
includes all details about the bug, including a description of
the user-visible effects of the bug.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Serge Hallyn <serge.hallyn@canonical.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"Dmitry V. Levin" <ldv@altlinux.org>,
Pavel Emelyanov <xemul@openvz.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Doug Ledford <dledford@redhat.com>,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [PATCH] ns: move free_nsproxy() out of do_exit() path
Date: Fri, 13 Jul 2012 14:08:06 -0700 [thread overview]
Message-ID: <20120713140806.b3d0fda8.akpm@linux-foundation.org> (raw)
In-Reply-To: <1342180088-22647-1-git-send-email-kirill.shutemov@linux.intel.com>
On Fri, 13 Jul 2012 14:48:08 +0300
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote:
> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
>
> free_nsproxy() is too heavy to be on exit path. Let's free namespaces
> asynchronously to not block exit_group() syscall.
Please be specific, and complete.
Why is it "too heavy"? Where is the time being spent? Is it spent in
D state or is it spent burning CPU cycles? Does the patch simply
offload the work into kernel threads, providing no net gain?
> The patch also fixes bug with free namespace without synchronize_rcu() through
> put_nsproxy().
I just don't understand this description. Please send a new one which
includes all details about the bug, including a description of
the user-visible effects of the bug.
next prev parent reply other threads:[~2012-07-13 21:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 11:48 [PATCH] ns: move free_nsproxy() out of do_exit() path Kirill A. Shutemov
2012-07-13 11:48 ` Kirill A. Shutemov
[not found] ` <1342180088-22647-1-git-send-email-kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2012-07-13 21:08 ` Andrew Morton [this message]
2012-07-13 21:08 ` Andrew Morton
[not found] ` <20120713140806.b3d0fda8.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-07-13 22:23 ` Kirill A. Shutemov
2012-07-13 22:23 ` Kirill A. Shutemov
2012-07-16 15:09 ` [PATCH v2] ns: do not block exit_task_namespaces() for a long time Kirill A. Shutemov
2012-07-16 15:09 ` Kirill A. Shutemov
2012-07-16 15:39 ` Myklebust, Trond
[not found] ` <1342453174.4648.6.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2012-07-16 16:39 ` Kirill A. Shutemov
2012-07-16 16:39 ` Kirill A. Shutemov
2012-07-16 16:53 ` Myklebust, Trond
2012-07-16 16:53 ` Myklebust, Trond
[not found] ` <1342451364-14787-1-git-send-email-kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2012-07-16 15:39 ` Myklebust, Trond
2012-07-16 16:53 ` Al Viro
2012-07-16 16:53 ` Al Viro
[not found] ` <20120716165301.GN31729-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2012-07-16 17:16 ` Kirill A. Shutemov
2012-07-16 17:16 ` Kirill A. Shutemov
[not found] ` <20120716171634.GA21620-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2012-07-16 17:22 ` Al Viro
2012-07-16 17:22 ` Al Viro
2012-07-16 21:05 ` Kirill A. Shutemov
2012-07-16 21:05 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713140806.b3d0fda8.akpm@linux-foundation.org \
--to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=ldv-u2l5PoMzF/Vg9hUCZPvPmw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
--cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.