From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marek Belisko <marek.belisko@open-nandra.com>
Cc: tiwai@suse.de, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH 1/2] sound:soc:soc-dmap: Fix compilation warning.
Date: Fri, 13 Jul 2012 15:45:24 +0100 [thread overview]
Message-ID: <20120713144524.GO4215@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1342126816-22308-1-git-send-email-marek.belisko@open-nandra.com>
[-- Attachment #1.1: Type: text/plain, Size: 470 bytes --]
On Thu, Jul 12, 2012 at 11:00:16PM +0200, Marek Belisko wrote:
> Fix following:
> sound/soc/soc-dapm.c: In function ‘dapm_clock_event’:
> sound/soc/soc-dapm.c:1021:1: warning: control reaches end of non-void function [-Wreturn-type]
Applied,:but:please:do:make:an:effort:to:use:subject:lines:appropriate:to
the:subsystem. As well as using a totally different style there's a
spelling issue, I very nearly deleted the patch unread because of these
things.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marek Belisko <marek.belisko@open-nandra.com>
Cc: lrg@ti.com, perex@perex.cz, tiwai@suse.de,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] sound:soc:soc-dmap: Fix compilation warning.
Date: Fri, 13 Jul 2012 15:45:24 +0100 [thread overview]
Message-ID: <20120713144524.GO4215@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1342126816-22308-1-git-send-email-marek.belisko@open-nandra.com>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Thu, Jul 12, 2012 at 11:00:16PM +0200, Marek Belisko wrote:
> Fix following:
> sound/soc/soc-dapm.c: In function ‘dapm_clock_event’:
> sound/soc/soc-dapm.c:1021:1: warning: control reaches end of non-void function [-Wreturn-type]
Applied,:but:please:do:make:an:effort:to:use:subject:lines:appropriate:to
the:subsystem. As well as using a totally different style there's a
spelling issue, I very nearly deleted the patch unread because of these
things.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-13 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 21:00 [PATCH 1/2] sound:soc:soc-dmap: Fix compilation warning Marek Belisko
2012-07-13 14:45 ` Mark Brown [this message]
2012-07-13 14:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713144524.GO4215@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=marek.belisko@open-nandra.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.