From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Yong Shen <yong.shen@linaro.org>,
Fabio Estevam <fabio.estevam@freescale.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Arnaud Patard <arnaud.patard@rtp-net.org>,
Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] regulator: mc13xxx: Populate selector from mc13xxx_fixed_regulator_set_voltage
Date: Fri, 13 Jul 2012 17:34:48 +0100 [thread overview]
Message-ID: <20120713163448.GQ4215@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1342191674.10881.2.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Fri, Jul 13, 2012 at 11:01:14PM +0800, Axel Lin wrote:
> Not very sure if we should implement set_voltage callback for fixed voltage.
> ( Other drivers do not implement set_voltage callback for fixed voltage.
> Since the voltage is fixed, implement set_voltage callback seems does not make sense.)
We shouldn't normally implement it. The fixed voltage driver does so
because it reuses the existing set voltage device tree binding to
specify the voltage it provides but I'd not expect other drivers to need
to do this.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-13 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 15:01 [PATCH RFC] regulator: mc13xxx: Populate selector from mc13xxx_fixed_regulator_set_voltage Axel Lin
2012-07-13 16:34 ` Mark Brown [this message]
2012-08-01 19:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713163448.GQ4215@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnaud.patard@rtp-net.org \
--cc=axel.lin@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=yong.shen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.