[PATCH RFC] regulator: mc13xxx: Populate selector from mc13xxx_fixed_regulator_set_voltage

[PATCH RFC] regulator: mc13xxx: Populate selector from mc13xxx_fixed_regulator_set_voltage

[Axel Lin]

This was missing until now and the underlying
_regulator_do_set_voltage is using this value when calling list_voltage.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
Not very sure if we should implement set_voltage callback for fixed voltage.
( Other drivers do not implement set_voltage callback for fixed voltage.
Since the voltage is fixed, implement set_voltage callback seems does not make sense.)

If we do implement the callback, we need to populate selector.
Or alternative, we can just remove mc13xxx_fixed_regulator_set_voltage.

Axel
 drivers/regulator/mc13xxx-regulator-core.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
index d6eda28..8151889 100644
--- a/drivers/regulator/mc13xxx-regulator-core.c
+++ b/drivers/regulator/mc13xxx-regulator-core.c
@@ -143,10 +143,12 @@ int mc13xxx_fixed_regulator_set_voltage(struct regulator_dev *rdev, int min_uV,
 		__func__, id, min_uV, max_uV);
 
 	if (min_uV <= rdev->desc->volt_table[0] &&
-	    rdev->desc->volt_table[0] <= max_uV)
+	    rdev->desc->volt_table[0] <= max_uV) {
+		*selector = 0;
 		return 0;
-	else
+	} else {
 		return -EINVAL;
+	}
 }
 EXPORT_SYMBOL_GPL(mc13xxx_fixed_regulator_set_voltage);
 
-- 
1.7.9.5

Re: [PATCH RFC] regulator: mc13xxx: Populate selector from mc13xxx_fixed_regulator_set_voltage

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

On Fri, Jul 13, 2012 at 11:01:14PM +0800, Axel Lin wrote:

> Not very sure if we should implement set_voltage callback for fixed voltage.
> ( Other drivers do not implement set_voltage callback for fixed voltage.
> Since the voltage is fixed, implement set_voltage callback seems does not make sense.)

We shouldn't normally implement it.  The fixed voltage driver does so
because it reuses the existing set voltage device tree binding to
specify the voltage it provides but I'd not expect other drivers to need
to do this.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH RFC] regulator: mc13xxx: Populate selector from mc13xxx_fixed_regulator_set_voltage

[Mark Brown]

On Fri, Jul 13, 2012 at 11:01:14PM +0800, Axel Lin wrote:
> This was missing until now and the underlying
> _regulator_do_set_voltage is using this value when calling list_voltage.

Applied, thanks.