All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <khilman@ti.com>, Joe Woodward <jw@terrafix.co.uk>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP3: clockdomain: fix accidental duplicate registration
Date: Mon, 16 Jul 2012 01:36:09 -0700	[thread overview]
Message-ID: <20120716083609.GG6522@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1207141150340.3876@utopia.booyaka.com>

* Paul Walmsley <paul@pwsan.com> [120714 10:59]:
> On Sat, 14 Jul 2012, Tony Lindgren wrote:
> 
> > The patch seems to produce a new warning against arm soc tree 
> > next/cleanup branch:
> > 
> > warning: ‘mpu_3xxx_clkdm’ defined but not used
> > 
> > Paul, care to check if a change is needed for the arm soc tree
> > next/cleanup branch version of this patch?
> 
> arm-soc next/cleanup branch doesn't include commit 16e5e2c4 ("ARM: OMAP 
> AM35x: clockdomain data: Fix clockdomain dependencies").  So that patch 
> won't apply there, and the copy of mach-omap2/clockdomains3xxx_data.c in 
> that branch is clean.

Hmm well it seems that we should apply this fix into arm-soc next/cleanup
branch if that's where the mismerge happened? It seems the same mismerge
is there even without 16e5e2c4?

You patch applies into arm-soc next/cleanup with fuzz:

patching file arch/arm/mach-omap2/clockdomain.c
patching file arch/arm/mach-omap2/clockdomain.h
Hunk #1 succeeded at 82 (offset -4 lines).
patching file arch/arm/mach-omap2/clockdomains3xxx_data.c
Hunk #1 succeeded at 347 with fuzz 2 (offset -107 lines).

So that's why I'm wondering if it needs some changes.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP3: clockdomain: fix accidental duplicate registration
Date: Mon, 16 Jul 2012 01:36:09 -0700	[thread overview]
Message-ID: <20120716083609.GG6522@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1207141150340.3876@utopia.booyaka.com>

* Paul Walmsley <paul@pwsan.com> [120714 10:59]:
> On Sat, 14 Jul 2012, Tony Lindgren wrote:
> 
> > The patch seems to produce a new warning against arm soc tree 
> > next/cleanup branch:
> > 
> > warning: ?mpu_3xxx_clkdm? defined but not used
> > 
> > Paul, care to check if a change is needed for the arm soc tree
> > next/cleanup branch version of this patch?
> 
> arm-soc next/cleanup branch doesn't include commit 16e5e2c4 ("ARM: OMAP 
> AM35x: clockdomain data: Fix clockdomain dependencies").  So that patch 
> won't apply there, and the copy of mach-omap2/clockdomains3xxx_data.c in 
> that branch is clean.

Hmm well it seems that we should apply this fix into arm-soc next/cleanup
branch if that's where the mismerge happened? It seems the same mismerge
is there even without 16e5e2c4?

You patch applies into arm-soc next/cleanup with fuzz:

patching file arch/arm/mach-omap2/clockdomain.c
patching file arch/arm/mach-omap2/clockdomain.h
Hunk #1 succeeded at 82 (offset -4 lines).
patching file arch/arm/mach-omap2/clockdomains3xxx_data.c
Hunk #1 succeeded at 347 with fuzz 2 (offset -107 lines).

So that's why I'm wondering if it needs some changes.

Regards,

Tony

  reply	other threads:[~2012-07-16  8:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12 10:54 [PATCH] ARM: OMAP3: clockdomain: fix accidental duplicate registration Paul Walmsley
2012-07-12 10:54 ` Paul Walmsley
2012-07-12 17:50 ` Kevin Hilman
2012-07-12 17:50   ` Kevin Hilman
2012-07-13  6:47   ` Tony Lindgren
2012-07-13  6:47     ` Tony Lindgren
2012-07-14  8:52     ` Tony Lindgren
2012-07-14  8:52       ` Tony Lindgren
2012-07-14 17:54       ` Paul Walmsley
2012-07-14 17:54         ` Paul Walmsley
2012-07-16  8:36         ` Tony Lindgren [this message]
2012-07-16  8:36           ` Tony Lindgren
2012-07-18  9:53           ` Paul Walmsley
2012-07-18  9:53             ` Paul Walmsley
2012-07-19 11:52             ` Tony Lindgren
2012-07-19 11:52               ` Tony Lindgren
2012-07-19 19:12               ` Paul Walmsley
2012-07-19 19:12                 ` Paul Walmsley
2012-07-24  8:16                 ` Tony Lindgren
2012-07-24  8:16                   ` Tony Lindgren
2012-07-24 20:52                   ` Paul Walmsley
2012-07-24 20:52                     ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120716083609.GG6522@atomide.com \
    --to=tony@atomide.com \
    --cc=jw@terrafix.co.uk \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.