All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
	David Woodhouse <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer
Date: Mon, 16 Jul 2012 09:38:19 +0000	[thread overview]
Message-ID: <201207161138.19985.sr@denx.de> (raw)
In-Reply-To: <1341997118-25042-1-git-send-email-Julia.Lawall@lip6.fr>

On Wednesday 11 July 2012 10:58:38 Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> dev_get_platdata returns a pointer, so the failure value would be NULL
> rather than a negative integer.
> 
> The semantic match that finds this problem is: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression x,e;
> statement S1,S2;
> @@
> 
> *x = dev_get_platdata(...)
> ... when != x = e
> *if (x < 0) S1 else S2
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Stefan Roese <sr@denx.de>
 
Thanks,
Stefan

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Roese <sr@denx.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
	David Woodhouse <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer
Date: Mon, 16 Jul 2012 11:38:19 +0200	[thread overview]
Message-ID: <201207161138.19985.sr@denx.de> (raw)
In-Reply-To: <1341997118-25042-1-git-send-email-Julia.Lawall@lip6.fr>

On Wednesday 11 July 2012 10:58:38 Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> dev_get_platdata returns a pointer, so the failure value would be NULL
> rather than a negative integer.
> 
> The semantic match that finds this problem is: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression x,e;
> statement S1,S2;
> @@
> 
> *x = dev_get_platdata(...)
> ... when != x = e
> *if (x < 0) S1 else S2
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Stefan Roese <sr@denx.de>
 
Thanks,
Stefan

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Roese <sr@denx.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: David Woodhouse <dwmw2@infradead.org>,
	kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer
Date: Mon, 16 Jul 2012 11:38:19 +0200	[thread overview]
Message-ID: <201207161138.19985.sr@denx.de> (raw)
In-Reply-To: <1341997118-25042-1-git-send-email-Julia.Lawall@lip6.fr>

On Wednesday 11 July 2012 10:58:38 Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> dev_get_platdata returns a pointer, so the failure value would be NULL
> rather than a negative integer.
> 
> The semantic match that finds this problem is: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression x,e;
> statement S1,S2;
> @@
> 
> *x = dev_get_platdata(...)
> ... when != x = e
> *if (x < 0) S1 else S2
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Stefan Roese <sr@denx.de>
 
Thanks,
Stefan

  parent reply	other threads:[~2012-07-16  9:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11  8:58 [PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer Julia Lawall
2012-07-11  8:58 ` Julia Lawall
2012-07-11  8:58 ` Julia Lawall
2012-07-11  9:01 ` viresh kumar
2012-07-11  9:01   ` viresh kumar
2012-07-11  9:01   ` viresh kumar
2012-07-16  9:38 ` Stefan Roese [this message]
2012-07-16  9:38   ` Stefan Roese
2012-07-16  9:38   ` Stefan Roese
2012-08-04 20:36 ` [PATCH] drivers/mtd/devices/spear_smi.c: use devm_ functions consistently Julia Lawall
2012-08-04 20:36   ` Julia Lawall
2012-08-04 20:36   ` Julia Lawall
2012-08-24 11:35   ` Artem Bityutskiy
2012-08-24 11:35     ` Artem Bityutskiy
2012-08-24 11:35     ` Artem Bityutskiy
2012-08-24 13:14     ` Stefan Roese
2012-08-24 13:14       ` Stefan Roese
2012-08-24 13:14       ` Stefan Roese
2012-08-24 14:43       ` Artem Bityutskiy
2012-08-24 14:43         ` Artem Bityutskiy
2012-08-24 14:43         ` Artem Bityutskiy
2012-08-17  9:59 ` [PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer Artem Bityutskiy
2012-08-17 10:03   ` Artem Bityutskiy
2012-08-17 10:03   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207161138.19985.sr@denx.de \
    --to=sr@denx.de \
    --cc=Julia.Lawall@lip6.fr \
    --cc=dwmw2@infradead.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.