All of lore.kernel.org
 help / color / mirror / Atom feed
From: sameo@linux.intel.com (Samuel Ortiz)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe
Date: Mon, 16 Jul 2012 15:41:51 +0200	[thread overview]
Message-ID: <20120716134151.GH20652@sortiz-mobl> (raw)
In-Reply-To: <1342006608-30550-1-git-send-email-u.kleine-koenig@pengutronix.de>

Hi Uwe,

On Wed, Jul 11, 2012 at 01:36:48PM +0200, Uwe Kleine-K?nig wrote:
> This was introduced in commit
> 
> 	876989d (mfd: Add device tree probe support for mc13xxx)
> 
> for spi and later while introducing support for i2c copied to the i2c
> driver.
> 
> Modifying driver details is very strange, for example probing an
> mc13892 device (instantiated via dt) removes the driver's ability to
> handle (traditionally probed) mc13783 devices in this case.
> I'm not aware of any problems that make this hack necessary and if
> there were some, they'd have to be fixed in the spi/i2c core, not in
> a driver.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> Hello Samuel,
> 
> even though this qualifies as fix, I don't think it's necessary to annoy
> Linus with it for 3.5. Usually there is only one pmic on each machine so
> it's not grave when probing one device disables support for another.
I agree, and I'm pushing this one for the next merge window.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

WARNING: multiple messages have this Message-ID (diff)
From: Samuel Ortiz <sameo@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
	"Philippe Rétornaz" <philippe.retornaz@epfl.ch>,
	"Marc Reilly" <marc@cpdesign.com.au>,
	"Mark Brown" <broonie@opensource.wolfsonmicro.com>
Subject: Re: [RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe
Date: Mon, 16 Jul 2012 15:41:51 +0200	[thread overview]
Message-ID: <20120716134151.GH20652@sortiz-mobl> (raw)
In-Reply-To: <1342006608-30550-1-git-send-email-u.kleine-koenig@pengutronix.de>

Hi Uwe,

On Wed, Jul 11, 2012 at 01:36:48PM +0200, Uwe Kleine-König wrote:
> This was introduced in commit
> 
> 	876989d (mfd: Add device tree probe support for mc13xxx)
> 
> for spi and later while introducing support for i2c copied to the i2c
> driver.
> 
> Modifying driver details is very strange, for example probing an
> mc13892 device (instantiated via dt) removes the driver's ability to
> handle (traditionally probed) mc13783 devices in this case.
> I'm not aware of any problems that make this hack necessary and if
> there were some, they'd have to be fixed in the spi/i2c core, not in
> a driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello Samuel,
> 
> even though this qualifies as fix, I don't think it's necessary to annoy
> Linus with it for 3.5. Usually there is only one pmic on each machine so
> it's not grave when probing one device disables support for another.
I agree, and I'm pushing this one for the next merge window.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

  parent reply	other threads:[~2012-07-16 13:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 11:36 [RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe Uwe Kleine-König
2012-07-11 11:36 ` Uwe Kleine-König
2012-07-12  1:10 ` Shawn Guo
2012-07-12  1:10   ` Shawn Guo
2012-07-16 13:41 ` Samuel Ortiz [this message]
2012-07-16 13:41   ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120716134151.GH20652@sortiz-mobl \
    --to=sameo@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.