From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Theodore Ts'o <tytso@mit.edu>, Zheng Liu <wenqing.lz@taobao.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] ext4: locking issue on error path
Date: Tue, 17 Jul 2012 08:13:51 +0000 [thread overview]
Message-ID: <20120717081351.GA4513@gmail.com> (raw)
In-Reply-To: <20120717063106.GA14985@elgon.mountain>
On Tue, Jul 17, 2012 at 09:31:06AM +0300, Dan Carpenter wrote:
> We recently changed how the locking worked here, but this error path was
> missed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Sorry, it is my fault. Thanks for pointing out this bug.
Regards,
Zheng
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 8c84070..2728fb7 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3031,8 +3031,10 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb,
> if (!is_sync_kiocb(iocb)) {
> ext4_io_end_t *io_end > ext4_init_io_end(inode, GFP_NOFS);
> - if (!io_end)
> - return -ENOMEM;
> + if (!io_end) {
> + ret = -ENOMEM;
> + goto retake_lock;
> + }
> io_end->flag |= EXT4_IO_END_DIRECT;
> iocb->private = io_end;
> /*
> @@ -3094,6 +3096,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb,
> ext4_clear_inode_state(inode, EXT4_STATE_DIO_UNWRITTEN);
> }
>
> +retake_lock:
> /* take i_mutex locking again if we do a ovewrite dio */
> if (overwrite) {
> up_read(&EXT4_I(inode)->i_data_sem);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Theodore Ts'o <tytso@mit.edu>, Zheng Liu <wenqing.lz@taobao.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] ext4: locking issue on error path
Date: Tue, 17 Jul 2012 16:13:51 +0800 [thread overview]
Message-ID: <20120717081351.GA4513@gmail.com> (raw)
In-Reply-To: <20120717063106.GA14985@elgon.mountain>
On Tue, Jul 17, 2012 at 09:31:06AM +0300, Dan Carpenter wrote:
> We recently changed how the locking worked here, but this error path was
> missed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Sorry, it is my fault. Thanks for pointing out this bug.
Regards,
Zheng
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 8c84070..2728fb7 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3031,8 +3031,10 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb,
> if (!is_sync_kiocb(iocb)) {
> ext4_io_end_t *io_end =
> ext4_init_io_end(inode, GFP_NOFS);
> - if (!io_end)
> - return -ENOMEM;
> + if (!io_end) {
> + ret = -ENOMEM;
> + goto retake_lock;
> + }
> io_end->flag |= EXT4_IO_END_DIRECT;
> iocb->private = io_end;
> /*
> @@ -3094,6 +3096,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb,
> ext4_clear_inode_state(inode, EXT4_STATE_DIO_UNWRITTEN);
> }
>
> +retake_lock:
> /* take i_mutex locking again if we do a ovewrite dio */
> if (overwrite) {
> up_read(&EXT4_I(inode)->i_data_sem);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-07-17 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 6:31 [patch -next] ext4: locking issue on error path Dan Carpenter
2012-07-17 6:31 ` Dan Carpenter
2012-07-17 8:13 ` Zheng Liu [this message]
2012-07-17 8:13 ` Zheng Liu
2012-07-23 0:20 ` Theodore Ts'o
2012-07-23 0:20 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717081351.GA4513@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.