From: Ram Pai <linuxram@us.ibm.com>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ram Pai <linuxram@us.ibm.com>,
linux-pci@vger.kernel.org, linuxppc-dev@ozlabs.org,
yinghai@kernel.org
Subject: Re: [PATCH 05/15] pci: resource assignment based on p2p alignment
Date: Wed, 18 Jul 2012 13:02:27 +0800 [thread overview]
Message-ID: <20120718050227.GC2375@ram-ThinkPad-T61> (raw)
In-Reply-To: <20120718010746.GA4238@shangw>
On Wed, Jul 18, 2012 at 09:07:46AM +0800, Gavin Shan wrote:
> 4. Either "b_res->flags & mask" or "type" to be used for window_alignment(),
> I don't think it's big deal because "b_res->flags & mask == type" for
> current implementation. However, I'm not sure I still need change it
> to "type"?
>
> min_align = max(min_align, window_alignment(bus, b_res->flags & mask));
Ah. you are right.
(b_res->flags & mask) or type, either one is ok. I had a wrong
assumption about b_res->flags. I thought it has either IORESOURCE_MEM
set or IORESOURCE_PREFETCH set, but not both.
Whatever concern I had, i dont have it any more.
RP
WARNING: multiple messages have this Message-ID (diff)
From: Ram Pai <linuxram@us.ibm.com>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: Ram Pai <linuxram@us.ibm.com>,
linuxppc-dev@ozlabs.org, linux-pci@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
yinghai@kernel.org
Subject: Re: [PATCH 05/15] pci: resource assignment based on p2p alignment
Date: Wed, 18 Jul 2012 13:02:27 +0800 [thread overview]
Message-ID: <20120718050227.GC2375@ram-ThinkPad-T61> (raw)
In-Reply-To: <20120718010746.GA4238@shangw>
On Wed, Jul 18, 2012 at 09:07:46AM +0800, Gavin Shan wrote:
> 4. Either "b_res->flags & mask" or "type" to be used for window_alignment(),
> I don't think it's big deal because "b_res->flags & mask == type" for
> current implementation. However, I'm not sure I still need change it
> to "type"?
>
> min_align = max(min_align, window_alignment(bus, b_res->flags & mask));
Ah. you are right.
(b_res->flags & mask) or type, either one is ok. I had a wrong
assumption about b_res->flags. I thought it has either IORESOURCE_MEM
set or IORESOURCE_PREFETCH set, but not both.
Whatever concern I had, i dont have it any more.
RP
next prev parent reply other threads:[~2012-07-18 5:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1342491799-30303-1-git-send-email-shangw@linux.vnet.ibm.com>
2012-07-17 3:40 ` [PATCH v6 0/7] minimal alignment for p2p bars Ram Pai
2012-07-17 3:40 ` Ram Pai
[not found] ` <1342491799-30303-6-git-send-email-shangw@linux.vnet.ibm.com>
2012-07-17 5:05 ` [PATCH 05/15] pci: resource assignment based on p2p alignment Ram Pai
2012-07-17 5:05 ` Ram Pai
2012-07-17 5:23 ` Ram Pai
2012-07-17 5:23 ` Ram Pai
[not found] ` <20120717053648.GA18497@shangw>
2012-07-17 5:57 ` Ram Pai
2012-07-17 5:57 ` Ram Pai
2012-07-17 9:16 ` Benjamin Herrenschmidt
2012-07-17 9:16 ` Benjamin Herrenschmidt
2012-07-17 10:03 ` Ram Pai
2012-07-17 10:03 ` Ram Pai
2012-07-17 10:38 ` Benjamin Herrenschmidt
2012-07-17 10:38 ` Benjamin Herrenschmidt
2012-07-17 17:14 ` Bjorn Helgaas
2012-07-17 17:14 ` Bjorn Helgaas
2012-07-18 4:25 ` Ram Pai
2012-07-18 4:25 ` Ram Pai
2012-07-18 16:59 ` Bjorn Helgaas
2012-07-18 16:59 ` Bjorn Helgaas
2012-07-19 7:24 ` Gavin Shan
[not found] ` <20120718010746.GA4238@shangw>
2012-07-18 5:02 ` Ram Pai [this message]
2012-07-18 5:02 ` Ram Pai
2012-07-18 4:28 ` Ram Pai
2012-07-18 4:28 ` Ram Pai
2012-06-29 6:47 [PATCH V5 0/7] minimal alignment for p2p bars Gavin Shan
[not found] ` <1342452631-21152-5-git-send-email-shangw@linux.vnet.ibm.com>
2012-07-17 0:47 ` [PATCH 05/15] pci: resource assignment based on p2p alignment Bjorn Helgaas
2012-07-17 0:47 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718050227.GC2375@ram-ThinkPad-T61 \
--to=linuxram@us.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=shangw@linux.vnet.ibm.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.