From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Hui Wang <jason77.wang@gmail.com>,
linux-can@vger.kernel.org, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH] can: flexcan: add 2nd clock to support imx53 and newer
Date: Wed, 18 Jul 2012 10:49:44 +0200 [thread overview]
Message-ID: <20120718084944.GD30009@pengutronix.de> (raw)
In-Reply-To: <500675C2.9090303@pengutronix.de>
On Wed, Jul 18, 2012 at 10:37:22AM +0200, Marc Kleine-Budde wrote:
>
> Yes, good catch.
>
> Is it allowed to call clk_put with a NULL pointer?
As NULL is a valid clock by definition it is allowed to do this.
However, calling clk_put with a NULL pointer when a corresponding
call to clk_get never returned NULL is probably not a good idea.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] can: flexcan: add 2nd clock to support imx53 and newer
Date: Wed, 18 Jul 2012 10:49:44 +0200 [thread overview]
Message-ID: <20120718084944.GD30009@pengutronix.de> (raw)
In-Reply-To: <500675C2.9090303@pengutronix.de>
On Wed, Jul 18, 2012 at 10:37:22AM +0200, Marc Kleine-Budde wrote:
>
> Yes, good catch.
>
> Is it allowed to call clk_put with a NULL pointer?
As NULL is a valid clock by definition it is allowed to do this.
However, calling clk_put with a NULL pointer when a corresponding
call to clk_get never returned NULL is probably not a good idea.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-07-18 8:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 22:05 [PATCH] can: flexcan: add 2nd clock to support imx53 and newer Marc Kleine-Budde
2012-07-17 22:05 ` Marc Kleine-Budde
2012-07-18 2:12 ` Hui Wang
2012-07-18 2:12 ` Hui Wang
2012-07-18 8:37 ` Marc Kleine-Budde
2012-07-18 8:37 ` Marc Kleine-Budde
2012-07-18 8:48 ` Hui Wang
2012-07-18 8:48 ` Hui Wang
2012-07-18 8:49 ` Sascha Hauer [this message]
2012-07-18 8:49 ` Sascha Hauer
2012-07-18 9:05 ` Lothar Waßmann
2012-07-18 9:05 ` Lothar Waßmann
2012-07-18 9:21 ` Marc Kleine-Budde
2012-07-18 9:21 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718084944.GD30009@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=jason77.wang@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.