From: Olaf Hering <olaf@aepfle.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Bryan Wu <bryan.wu@canonical.com>,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] led: use correct name for /sys/devices/virtual/leds/ entries
Date: Wed, 18 Jul 2012 19:32:56 +0200 [thread overview]
Message-ID: <20120718173256.GA21359@aepfle.de> (raw)
In-Reply-To: <5006EBD4.8010601@metafoo.de>
On Wed, Jul 18, Lars-Peter Clausen wrote:
> That's a LED trigger, not a LED. So the LED naming convention doesn't apply
> here and it does not even make sense to try to apply it. Also the patch
> breaks all users of the default-on trigger.
Thanks for the review. The real fix was applied in db3f5207, no idea why
I changed also this file. Up to now noone noticed the name change.
Olaf
prev parent reply other threads:[~2012-07-18 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 16:49 [PATCH] led: use correct name for /sys/devices/virtual/leds/ entries olaf
2012-07-18 17:01 ` Lars-Peter Clausen
2012-07-18 17:32 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718173256.GA21359@aepfle.de \
--to=olaf@aepfle.de \
--cc=bryan.wu@canonical.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.