* [PATCH] led: use correct name for /sys/devices/virtual/leds/ entries
@ 2012-07-18 16:49 olaf
2012-07-18 17:01 ` Lars-Peter Clausen
0 siblings, 1 reply; 3+ messages in thread
From: olaf @ 2012-07-18 16:49 UTC (permalink / raw)
To: Bryan Wu, Richard Purdie; +Cc: linux-leds, linux-kernel, Olaf Hering
From: Olaf Hering <olaf@aepfle.de>
Follow naming according to Documentation/leds/leds-class.txt:
LED Device Naming
Is currently of the form:
"devicename:colour:function"
Reported during openSuSE 11.1 testing.
https://bugzilla.novell.com/show_bug.cgi?&id=468350
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff --git a/drivers/leds/ledtrig-default-on.c b/drivers/leds/ledtrig-default-on.c
index a4ef54b..2efdd30 100644
--- a/drivers/leds/ledtrig-default-on.c
+++ b/drivers/leds/ledtrig-default-on.c
@@ -23,7 +23,7 @@ static void defon_trig_activate(struct led_classdev *led_cdev)
}
static struct led_trigger defon_led_trigger = {
- .name = "default-on",
+ .name = "default::on",
.activate = defon_trig_activate,
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] led: use correct name for /sys/devices/virtual/leds/ entries
2012-07-18 16:49 [PATCH] led: use correct name for /sys/devices/virtual/leds/ entries olaf
@ 2012-07-18 17:01 ` Lars-Peter Clausen
2012-07-18 17:32 ` Olaf Hering
0 siblings, 1 reply; 3+ messages in thread
From: Lars-Peter Clausen @ 2012-07-18 17:01 UTC (permalink / raw)
To: olaf; +Cc: Bryan Wu, Richard Purdie, linux-leds, linux-kernel
On 07/18/2012 06:49 PM, olaf@aepfle.de wrote:
> From: Olaf Hering <olaf@aepfle.de>
>
> Follow naming according to Documentation/leds/leds-class.txt:
> LED Device Naming
> Is currently of the form:
> "devicename:colour:function"
>
> Reported during openSuSE 11.1 testing.
> https://bugzilla.novell.com/show_bug.cgi?&id=468350
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> diff --git a/drivers/leds/ledtrig-default-on.c b/drivers/leds/ledtrig-default-on.c
> index a4ef54b..2efdd30 100644
> --- a/drivers/leds/ledtrig-default-on.c
> +++ b/drivers/leds/ledtrig-default-on.c
> @@ -23,7 +23,7 @@ static void defon_trig_activate(struct led_classdev *led_cdev)
> }
>
> static struct led_trigger defon_led_trigger = {
> - .name = "default-on",
> + .name = "default::on",
> .activate = defon_trig_activate,
> };
>
That's a LED trigger, not a LED. So the LED naming convention doesn't apply
here and it does not even make sense to try to apply it. Also the patch
breaks all users of the default-on trigger.
- Lars
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] led: use correct name for /sys/devices/virtual/leds/ entries
2012-07-18 17:01 ` Lars-Peter Clausen
@ 2012-07-18 17:32 ` Olaf Hering
0 siblings, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2012-07-18 17:32 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Bryan Wu, Richard Purdie, linux-leds, linux-kernel
On Wed, Jul 18, Lars-Peter Clausen wrote:
> That's a LED trigger, not a LED. So the LED naming convention doesn't apply
> here and it does not even make sense to try to apply it. Also the patch
> breaks all users of the default-on trigger.
Thanks for the review. The real fix was applied in db3f5207, no idea why
I changed also this file. Up to now noone noticed the name change.
Olaf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-18 17:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-18 16:49 [PATCH] led: use correct name for /sys/devices/virtual/leds/ entries olaf
2012-07-18 17:01 ` Lars-Peter Clausen
2012-07-18 17:32 ` Olaf Hering
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.