From: Dave Jones <davej@redhat.com>
To: Jim Rees <rees@umich.edu>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Sasha Levin <levinsasha928@gmail.com>,
Trond.Myklebust@netapp.com, davem@davemloft.net,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: Prevent kernel stack corruption on long values of flush
Date: Wed, 18 Jul 2012 16:33:04 -0400 [thread overview]
Message-ID: <20120718203304.GA18540@redhat.com> (raw)
In-Reply-To: <20120718200049.GA17964@umich.edu>
On Wed, Jul 18, 2012 at 04:00:49PM -0400, Jim Rees wrote:
> You could use something like:
>
> char tbuf[sizeof (unsigned long) * 24 / 10 + 1 + 2]; /* + 2 for final "\n\0" */
>
> since there are roughly 10 bits for every 3 decimal digits.
>
> But I'm obviously confused, because I don't understand why tbuf needs to be
> any more than 10 + 2.
Unsigned long isn't necessarily 32 bits.
On 64-bit systems %lu can be up to 18446744073709551615
Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Jim Rees <rees-63aXycvo3TyHXe+LvDLADg@public.gmane.org>
Cc: "J. Bruce Fields"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
Sasha Levin
<levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] SUNRPC: Prevent kernel stack corruption on long values of flush
Date: Wed, 18 Jul 2012 16:33:04 -0400 [thread overview]
Message-ID: <20120718203304.GA18540@redhat.com> (raw)
In-Reply-To: <20120718200049.GA17964-63aXycvo3TyHXe+LvDLADg@public.gmane.org>
On Wed, Jul 18, 2012 at 04:00:49PM -0400, Jim Rees wrote:
> You could use something like:
>
> char tbuf[sizeof (unsigned long) * 24 / 10 + 1 + 2]; /* + 2 for final "\n\0" */
>
> since there are roughly 10 bits for every 3 decimal digits.
>
> But I'm obviously confused, because I don't understand why tbuf needs to be
> any more than 10 + 2.
Unsigned long isn't necessarily 32 bits.
On 64-bit systems %lu can be up to 18446744073709551615
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-07-18 20:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 22:01 [PATCH] SUNRPC: Prevent kernel stack corruption on long values of flush Sasha Levin
2012-07-18 17:39 ` J. Bruce Fields
2012-07-18 20:00 ` Jim Rees
2012-07-18 20:33 ` Dave Jones [this message]
2012-07-18 20:33 ` Dave Jones
2012-07-18 20:55 ` Jim Rees
2012-07-18 20:55 ` Jim Rees
2012-10-17 18:29 ` Boaz Harrosh
2012-10-17 18:29 ` Boaz Harrosh
2012-10-18 8:34 ` David Laight
2012-10-18 8:34 ` David Laight
2012-10-18 8:34 ` David Laight
2012-07-18 21:08 ` J. Bruce Fields
2012-07-18 21:08 ` J. Bruce Fields
[not found] ` <50072BA7.6070205@gmail.com>
2012-07-18 21:43 ` Sasha Levin
2012-07-18 21:43 ` Sasha Levin
2012-07-18 23:04 ` Jim Rees
2012-07-18 23:04 ` Jim Rees
2012-10-17 17:59 ` Sasha Levin
2012-10-17 17:59 ` Sasha Levin
2012-10-17 19:02 ` J. Bruce Fields
2012-10-17 19:02 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718203304.GA18540@redhat.com \
--to=davej@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.