All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree.
Date: Thu, 19 Jul 2012 14:23:28 +0000	[thread overview]
Message-ID: <201207191423.28673.arnd@arndb.de> (raw)
In-Reply-To: <1342704684-4858-1-git-send-email-linux@prisktech.co.nz>

On Thursday 19 July 2012, Tony Prisk wrote:
> 
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> ---
>  drivers/usb/host/ehci-vt8500.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)

The addition is straightforward and looks correct, but I would suggest you
also add the new "compatible" values to
Documentation/devicetree/bindings/usb-ehci.txt

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: vt8500-wm8505-linux-kernel-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree.
Date: Thu, 19 Jul 2012 14:23:28 +0000	[thread overview]
Message-ID: <201207191423.28673.arnd@arndb.de> (raw)
In-Reply-To: <1342704684-4858-1-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>

On Thursday 19 July 2012, Tony Prisk wrote:
> 
> Signed-off-by: Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
> ---
>  drivers/usb/host/ehci-vt8500.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)

The addition is straightforward and looks correct, but I would suggest you
also add the new "compatible" values to
Documentation/devicetree/bindings/usb-ehci.txt

	Arnd

  parent reply	other threads:[~2012-07-19 14:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 13:31 [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree Tony Prisk
2012-07-19 13:31 ` Tony Prisk
2012-07-19 13:31 ` [PATCH 2/2] ARM: vt8500: Add support for UHCI companion controller Tony Prisk
2012-07-19 13:31   ` Tony Prisk
2012-07-19 14:27   ` Arnd Bergmann
2012-07-19 14:27     ` Arnd Bergmann
2012-07-19 14:23 ` Arnd Bergmann [this message]
2012-07-19 14:23   ` [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree Arnd Bergmann
2012-07-19 14:45 ` Alexey Charkov
2012-07-19 14:45   ` Alexey Charkov
2012-07-19 14:51   ` Tony Prisk
2012-07-19 14:51     ` Tony Prisk
2012-07-19 15:31   ` Tony Prisk
2012-07-19 15:31     ` Tony Prisk
  -- strict thread matches above, loose matches on Subject: below --
2012-07-19 16:07 Tony Prisk
2012-07-19 16:07 ` Tony Prisk
2012-07-21  2:00 Tony Prisk
2012-07-21  2:00 ` Tony Prisk
2012-07-21  2:00 ` Tony Prisk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207191423.28673.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.