* [PATCH] kernel: acct.c: spaces required around that '<'
@ 2012-07-19 21:10 jan.bannister
2012-07-19 22:55 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: jan.bannister @ 2012-07-19 21:10 UTC (permalink / raw)
To: viro, schwidefsky, linux-kernel; +Cc: Jan Bannister
From: Jan Bannister <jan.bannister@gmail.com>
Fixed a coding style issue
Signed-off-by: Jan Bannister <jan.bannister@gmail.com>
---
kernel/acct.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/acct.c b/kernel/acct.c
index 02e6167..725d3a9 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -134,7 +134,7 @@ static int check_free_space(struct bsd_acct_struct *acct, struct file *file)
spin_lock(&acct_lock);
if (file != acct->file) {
if (act)
- res = act>0;
+ res = act > 0;
goto out;
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] kernel: acct.c: spaces required around that '<'
2012-07-19 21:10 [PATCH] kernel: acct.c: spaces required around that '<' jan.bannister
@ 2012-07-19 22:55 ` Al Viro
0 siblings, 0 replies; 3+ messages in thread
From: Al Viro @ 2012-07-19 22:55 UTC (permalink / raw)
To: jan.bannister; +Cc: schwidefsky, linux-kernel
On Thu, Jul 19, 2012 at 10:10:27PM +0100, jan.bannister@gmail.com wrote:
> From: Jan Bannister <jan.bannister@gmail.com>
>
> Fixed a coding style issue
NAK, because I'm sick and tired of the pompous commit messages. I'm fine
with adding those spaces. However, I _do_ have a lot against the commit
messages like that. "Required"? By whom? Holy checkpatch.pl? "Coding
style issue" - completely uninformative; there all kinds of those.
FWIW, my prefernce would be something along the lines of "whitespace
tidy-up in <function or file name>". At least that says what happens
in commit and where is it happening...
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] kernel: acct.c: spaces required around that '<'
@ 2012-07-19 21:30 jan.bannister
0 siblings, 0 replies; 3+ messages in thread
From: jan.bannister @ 2012-07-19 21:30 UTC (permalink / raw)
To: viro; +Cc: schwidefsky, linux-kernel, Jan Bannister
From: Jan Bannister <jan.bannister@gmail.com>
Fixed a coding style issue
Signed-off-by: Jan Bannister <jan.bannister@gmail.com>
---
kernel/acct.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/acct.c b/kernel/acct.c
index 02e6167..725d3a9 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -134,7 +134,7 @@ static int check_free_space(struct bsd_acct_struct *acct, struct file *file)
spin_lock(&acct_lock);
if (file != acct->file) {
if (act)
- res = act>0;
+ res = act > 0;
goto out;
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-19 22:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-19 21:10 [PATCH] kernel: acct.c: spaces required around that '<' jan.bannister
2012-07-19 22:55 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2012-07-19 21:30 jan.bannister
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.