From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: AnilKumar Ch <anilkumar@ti.com>
Cc: tony@atomide.com, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data
Date: Fri, 20 Jul 2012 10:59:36 +0100 [thread overview]
Message-ID: <20120720095935.GQ4495@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1342766789-28148-2-git-send-email-anilkumar@ti.com>
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On Fri, Jul 20, 2012 at 12:16:26PM +0530, AnilKumar Ch wrote:
> + vio_reg: regulator@1 {
> + reg = <1>;
> + regulator-compatible = "vio";
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
Every regulator here has a rather large voltage range specified with no
consumers added. Are you sure these voltage ranges make sense in your
design and you've not just cut'n'pasted the entire voltage range that
your regulator supports without reference to what your board can do?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data
Date: Fri, 20 Jul 2012 10:59:36 +0100 [thread overview]
Message-ID: <20120720095935.GQ4495@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1342766789-28148-2-git-send-email-anilkumar@ti.com>
On Fri, Jul 20, 2012 at 12:16:26PM +0530, AnilKumar Ch wrote:
> + vio_reg: regulator at 1 {
> + reg = <1>;
> + regulator-compatible = "vio";
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
Every regulator here has a rather large voltage range specified with no
consumers added. Are you sure these voltage ranges make sense in your
design and you've not just cut'n'pasted the entire voltage range that
your regulator supports without reference to what your board can do?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120720/46545946/attachment.sig>
next prev parent reply other threads:[~2012-07-20 9:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 6:46 [PATCH 0/4] Add AM33XX regulators device tree data AnilKumar Ch
2012-07-20 6:46 ` AnilKumar Ch
2012-07-20 6:46 ` [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 " AnilKumar Ch
2012-07-20 6:46 ` AnilKumar Ch
2012-07-20 9:59 ` Mark Brown [this message]
2012-07-20 9:59 ` Mark Brown
2012-07-20 11:27 ` AnilKumar, Chimata
2012-07-20 11:27 ` AnilKumar, Chimata
2012-07-20 11:38 ` Mark Brown
2012-07-20 11:38 ` Mark Brown
2012-07-23 7:06 ` AnilKumar, Chimata
2012-07-23 7:06 ` AnilKumar, Chimata
2012-07-23 13:23 ` AnilKumar, Chimata
2012-07-23 13:23 ` AnilKumar, Chimata
2012-07-23 13:34 ` Mark Brown
2012-07-23 13:34 ` Mark Brown
2012-07-23 13:48 ` Lee Jones
2012-07-23 13:48 ` Lee Jones
2012-08-28 11:26 ` Lee Jones
2012-08-28 11:26 ` Lee Jones
2012-08-28 17:21 ` Mark Brown
2012-08-28 17:21 ` Mark Brown
2012-08-29 8:31 ` Lee Jones
2012-08-29 8:31 ` Lee Jones
2012-08-30 16:59 ` Mark Brown
2012-08-30 16:59 ` Mark Brown
2012-07-20 6:46 ` [PATCH RESEND 2/4] ARM: OMAP2+: AM33XX: Add tps65217 " AnilKumar Ch
2012-07-20 6:46 ` AnilKumar Ch
2012-07-20 10:01 ` Mark Brown
2012-07-20 10:01 ` Mark Brown
2012-07-20 6:46 ` [PATCH 3/4] arm/dts: Add tps65910 regulator DT data to am335x-evm.dts AnilKumar Ch
2012-07-20 6:46 ` AnilKumar Ch
2012-07-20 6:46 ` [PATCH 4/4] arm/dts: Add tps65217 regulator DT data to am335x-bone.dts AnilKumar Ch
2012-07-20 6:46 ` AnilKumar Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720095935.GQ4495@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anilkumar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.