From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH] qemu: add .exrc
Date: Fri, 20 Jul 2012 14:02:32 +0300 [thread overview]
Message-ID: <20120720110232.GC1357@redhat.com> (raw)
In-Reply-To: <CAFEAcA8to_9XmFPU-3NdN5Esg2Z8jEd8Pe0+KbaQ0Z==NOao_Q@mail.gmail.com>
On Fri, Jul 20, 2012 at 11:34:21AM +0100, Peter Maydell wrote:
> On 20 July 2012 11:26, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > From my .vimrc:
> >
> > au BufNewFile,BufRead */qemu/*.c,*/qemu/*.h,*/qemu/*.hx,*/qemu/*tool
> > setlocal ts=4 sw=4 et
>
> Basically I think editor preferences are a local matter which
> can reasonably differ between different developers, so they
> shouldn't be in the git repo.
This is why I simply set the shiftwidth and set indenting by space.
Clearly no "can reasonably differ" applies here.
> (a) haven't you just demonstrated that even vim users have
> different preferred settings?
No, it's the same with the addition of tabstop=4, which *is*
a matter of taste (how many spaces you want shown if you edit
a file with tabs, like a makefile).
> (b) where do we stop? emacs? bbedit? there are a lot of editors
> out there...
If people ask for it we can consider. I doubt it will be a real problem.
> In any case, 3 settings clearly don't encompass the whole of
> QEMU's coding style.
> The relevant bit of my .emacs tweaks about
> 20 different settings...
>
> -- PMM
If you don't use vim why do you even care about this patch?
--
MST
prev parent reply other threads:[~2012-07-20 11:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 14:29 [Qemu-devel] [PATCH] qemu: add .exrc Michael S. Tsirkin
2012-07-19 15:11 ` Peter Maydell
2012-07-19 15:24 ` Michael S. Tsirkin
2012-07-20 10:26 ` Stefan Hajnoczi
2012-07-20 10:34 ` Peter Maydell
2012-07-20 10:37 ` 陳韋任 (Wei-Ren Chen)
2012-07-20 11:02 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720110232.GC1357@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.