All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree.
Date: Fri, 20 Jul 2012 22:05:28 +0000	[thread overview]
Message-ID: <201207202205.28815.arnd@arndb.de> (raw)
In-Reply-To: <1342787373-2230-1-git-send-email-linux@prisktech.co.nz>

On Friday 20 July 2012, Tony Prisk wrote:
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> ---
>  .../devicetree/bindings/usb/vt8500-ehci.txt        |   10 ++++++++++
>  drivers/usb/host/ehci-vt8500.c                     |    9 +++++++++
>  2 files changed, 19 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/vt8500-ehci.txt

As mentioned, you need to Cc the USB mailing list and the EHCI maintainers:

$ ./scripts/get_maintainer.pl drivers/usb/host/ehci-vt8500.c -f
Alan Stern <stern@rowland.harvard.edu> (maintainer:USB EHCI DRIVER)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:USB SUBSYSTEM)
linux-usb at vger.kernel.org (open list:USB EHCI DRIVER)
linux-kernel at vger.kernel.org (open list)


> diff --git a/Documentation/devicetree/bindings/usb/vt8500-ehci.txt b/Documentation/devicetree/bindings/usb/vt8500-ehci.txt
> new file mode 100644
> index 0000000..74f75c6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/vt8500-ehci.txt
> @@ -0,0 +1,10 @@
> +VIA VT8500 and Wondermedia WM8xxx SoC USB controllers.
> +
> +Required properties:
> + - compatible: Should be "via,vt8500-ehci" or "wm,prizm-ehci".

I would list the interrupts and reg properties as required as well,
and you can mention that there must be exactly one interrupt and one
reg resource with a length of 0x200 bytes.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
Cc: vt8500-wm8505-linux-kernel-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCHv2 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree.
Date: Fri, 20 Jul 2012 22:05:28 +0000	[thread overview]
Message-ID: <201207202205.28815.arnd@arndb.de> (raw)
In-Reply-To: <1342787373-2230-1-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>

On Friday 20 July 2012, Tony Prisk wrote:
> Signed-off-by: Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
> ---
>  .../devicetree/bindings/usb/vt8500-ehci.txt        |   10 ++++++++++
>  drivers/usb/host/ehci-vt8500.c                     |    9 +++++++++
>  2 files changed, 19 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/vt8500-ehci.txt

As mentioned, you need to Cc the USB mailing list and the EHCI maintainers:

$ ./scripts/get_maintainer.pl drivers/usb/host/ehci-vt8500.c -f
Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> (maintainer:USB EHCI DRIVER)
Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> (supporter:USB SUBSYSTEM)
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:USB EHCI DRIVER)
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)


> diff --git a/Documentation/devicetree/bindings/usb/vt8500-ehci.txt b/Documentation/devicetree/bindings/usb/vt8500-ehci.txt
> new file mode 100644
> index 0000000..74f75c6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/vt8500-ehci.txt
> @@ -0,0 +1,10 @@
> +VIA VT8500 and Wondermedia WM8xxx SoC USB controllers.
> +
> +Required properties:
> + - compatible: Should be "via,vt8500-ehci" or "wm,prizm-ehci".

I would list the interrupts and reg properties as required as well,
and you can mention that there must be exactly one interrupt and one
reg resource with a length of 0x200 bytes.

	Arnd

  parent reply	other threads:[~2012-07-20 22:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20 12:29 [PATCHv2 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree Tony Prisk
2012-07-20 12:29 ` Tony Prisk
2012-07-20 12:29 ` [PATCHv2 2/2] ARM: vt8500: Add support for UHCI companion controller Tony Prisk
2012-07-20 12:29   ` Tony Prisk
2012-07-20 22:10   ` Arnd Bergmann
2012-07-20 22:10     ` Arnd Bergmann
2012-07-21 16:19     ` Sergei Shtylyov
2012-07-21 16:19       ` Sergei Shtylyov
2012-07-20 22:05 ` Arnd Bergmann [this message]
2012-07-20 22:05   ` [PATCHv2 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207202205.28815.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.