All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 01/11] libgpg-error: add optional nls support
Date: Sun, 22 Jul 2012 16:20:52 +0200	[thread overview]
Message-ID: <20120722162052.544460b7@skate> (raw)
In-Reply-To: <1342963719-1810-2-git-send-email-s.martin49@gmail.com>

Le Sun, 22 Jul 2012 15:28:29 +0200,
Samuel Martin <s.martin49@gmail.com> a ?crit :

> +ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
> +LIBGPG_ERROR_DEPENDENCIES += gettext libintl
> +LIBGPG_ERROR_CONF_OPT += --enable-nls
> +else
> +LIBGPG_ERROR_CONF_OPT += --disable-nls
> +endif

This means that NLS support will always be enabled for uClibc
toolchains, and never be enabled for (e)glibc toolchains.

See the definition of BR2_NEEDS_GETTEXT and BR2_NEEDS_GETTEXT_IF_LOCALE:

---

# glibc and eglibc directly include gettext, so a separatly compiled
# gettext isn't needed and shouldn't be built to avoid conflicts. Some
# packages always need gettext, other packages only need gettext when
# locale support is enabled. See the documentation for how packages
# should rely on the following two options.

config BR2_NEEDS_GETTEXT
        bool
        default y if BR2_TOOLCHAIN_BUILDROOT
        default y if BR2_TOOLCHAIN_EXTERNAL_UCLIBC
        default y if BR2_TOOLCHAIN_CTNG_uClibc

config BR2_NEEDS_GETTEXT_IF_LOCALE
        bool
        default y if (BR2_NEEDS_GETTEXT && BR2_ENABLE_LOCALE)

---

The fact that there is a dependency on gettext+libintl for i18n support
on uClibc toolchains is correct. The fact that
--enable-nls/--disable-nls is decided depending on
BR2_NEEDS_GETTEXT_IF_LOCALE is not correct.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-07-22 14:20 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-22 13:28 [Buildroot] [PATCH 00/11] Misc. fixes for 2012.08 release Samuel Martin
2012-07-22 13:28 ` [Buildroot] [PATCH 01/11] libgpg-error: add optional nls support Samuel Martin
2012-07-22 14:20   ` Thomas Petazzoni [this message]
2012-07-22 13:28 ` [Buildroot] [PATCH 02/11] e2fsprogs: add staging install Samuel Martin
2012-07-22 14:21   ` Thomas Petazzoni
2012-10-10 21:22   ` Peter Korsgaard
2012-10-11  9:21     ` Samuel Martin
2012-07-22 13:28 ` [Buildroot] [PATCH 03/11] cleanup trailing white space Samuel Martin
2012-07-22 18:22   ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 04/11] elftosb: fix build forcing g++ compiler Samuel Martin
2012-07-22 17:20   ` Thomas Petazzoni
2012-07-22 18:32   ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 05/11] pkg-utils.mk: fix/clean indentation Samuel Martin
2012-07-22 18:22   ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 06/11] pkg-*targets.mk: factorize and fix $(PKG)_SRCDIR and $(PKG)_BUILDDIR declaration Samuel Martin
2012-07-22 18:22   ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 07/11] ext-tool.mk: add fancy messages Samuel Martin
2012-07-22 14:26   ` Thomas Petazzoni
2012-07-25 16:25     ` Arnout Vandecappelle
2012-07-25 16:32       ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 08/11] libpng: fix host-libpng build on system on which zlib.h is missing Samuel Martin
2012-07-22 14:27   ` Thomas Petazzoni
2012-07-25 17:39     ` Arnout Vandecappelle
2012-07-25 18:19       ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 09/11] m4: fix build with glibc >=2.16 Samuel Martin
2012-07-22 20:05   ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 10/11] tar: " Samuel Martin
2012-07-22 20:05   ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 11/11] libecore: " Samuel Martin
2012-07-22 14:45   ` Thomas Petazzoni
2012-10-10 21:28   ` Peter Korsgaard
2012-10-11  9:26     ` Samuel Martin
2012-10-11 15:15       ` Thomas Petazzoni
2012-10-13  9:38         ` Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120722162052.544460b7@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.