From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 07/11] ext-tool.mk: add fancy messages
Date: Sun, 22 Jul 2012 16:26:41 +0200 [thread overview]
Message-ID: <20120722162641.6bd3eeef@skate> (raw)
In-Reply-To: <1342963719-1810-8-git-send-email-s.martin49@gmail.com>
Le Sun, 22 Jul 2012 15:28:35 +0200,
Samuel Martin <s.martin49@gmail.com> a ?crit :
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index 293bf4f..0861673 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -65,6 +65,7 @@ INFLATE.tar = cat
>
> # MESSAGE Macro -- display a message in bold type
> MESSAGE = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION) $(1)$(TERM_RESET)"
> +MESSAGE2 = echo "$(TERM_BOLD)>>> $(1) $(2)$(TERM_RESET)"
> TERM_BOLD := $(shell tput smso)
> TERM_RESET := $(shell tput rmso)
Maybe we need:
MESSAGE = echo "$(TERM_BOLD)>>> $(1) $(2)$(TERM_RESET)"
PKG_MESSAGE = $(call MESSAGE,$($(PKG)_NAME) $($(PKG)_VERSION),$(1))
And then use PKG_MESSAGE in the package infrastructure, and MESSAGE in
other places. But definitely MESSAGE vs. MESSAGE2 is ugly.
And maybe the MESSAGE definition would have to be somewhere outside of
pkg-utils.mk since it's not package related anymore.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-07-22 14:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 13:28 [Buildroot] [PATCH 00/11] Misc. fixes for 2012.08 release Samuel Martin
2012-07-22 13:28 ` [Buildroot] [PATCH 01/11] libgpg-error: add optional nls support Samuel Martin
2012-07-22 14:20 ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 02/11] e2fsprogs: add staging install Samuel Martin
2012-07-22 14:21 ` Thomas Petazzoni
2012-10-10 21:22 ` Peter Korsgaard
2012-10-11 9:21 ` Samuel Martin
2012-07-22 13:28 ` [Buildroot] [PATCH 03/11] cleanup trailing white space Samuel Martin
2012-07-22 18:22 ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 04/11] elftosb: fix build forcing g++ compiler Samuel Martin
2012-07-22 17:20 ` Thomas Petazzoni
2012-07-22 18:32 ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 05/11] pkg-utils.mk: fix/clean indentation Samuel Martin
2012-07-22 18:22 ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 06/11] pkg-*targets.mk: factorize and fix $(PKG)_SRCDIR and $(PKG)_BUILDDIR declaration Samuel Martin
2012-07-22 18:22 ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 07/11] ext-tool.mk: add fancy messages Samuel Martin
2012-07-22 14:26 ` Thomas Petazzoni [this message]
2012-07-25 16:25 ` Arnout Vandecappelle
2012-07-25 16:32 ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 08/11] libpng: fix host-libpng build on system on which zlib.h is missing Samuel Martin
2012-07-22 14:27 ` Thomas Petazzoni
2012-07-25 17:39 ` Arnout Vandecappelle
2012-07-25 18:19 ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 09/11] m4: fix build with glibc >=2.16 Samuel Martin
2012-07-22 20:05 ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 10/11] tar: " Samuel Martin
2012-07-22 20:05 ` Thomas Petazzoni
2012-07-22 13:28 ` [Buildroot] [PATCH 11/11] libecore: " Samuel Martin
2012-07-22 14:45 ` Thomas Petazzoni
2012-10-10 21:28 ` Peter Korsgaard
2012-10-11 9:26 ` Samuel Martin
2012-10-11 15:15 ` Thomas Petazzoni
2012-10-13 9:38 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120722162641.6bd3eeef@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.