From: Marek Vasut <marex@denx.de>
To: Rob Herring <robherring2@gmail.com>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
linux-mtd@lists.infradead.org,
David Woodhouse <david.woodhouse@intel.com>,
dedekind1@gmail.com
Subject: Re: [PATCH V2] mtd: m25p80: Make fast read configurable via DT
Date: Mon, 23 Jul 2012 04:07:18 +0200 [thread overview]
Message-ID: <201207230407.18747.marex@denx.de> (raw)
In-Reply-To: <500CB097.4000507@gmail.com>
Dear Rob Herring,
> +devicetree-discuss
>
> On 07/22/2012 08:20 PM, Marek Vasut wrote:
> > Add DT property "m25p,fast-read" that signalises the particular
> > chip supports "fast read" opcode.
> >
> > NOTE: I'm not sure where to document this property, as m25p80 is
> >
> > a simple DT device. Any hints please?
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> > Cc: David Woodhouse <david.woodhouse@intel.com>
> > ---
> >
> > Documentation/devicetree/bindings/mtd/m25p80.txt | 27
> > ++++++++++++++++++ drivers/mtd/devices/m25p80.c |
> > 32 +++++++++++++--------- 2 files changed, 46 insertions(+), 13
> > deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/mtd/m25p80.txt
> >
> > V2: Add documentation for the DT property. (Thanks Rob Herring for
> > helping!)
> >
> > Supersedes [PATCH 3/3] [RFC] mtd: m25p80: Make fast read configurable
> > via DT
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/m25p80.txt
> > b/Documentation/devicetree/bindings/mtd/m25p80.txt new file mode 100644
> > index 0000000..e05d9b8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/m25p80.txt
> > @@ -0,0 +1,27 @@
> > +* MTD SPI driver for ST M25Pxx (and similar) serial flash chips
> > +
> > +Required properties:
> > +- #address-cells, #size-cells : Must be present if the device has
> > sub-nodes + representing partitions.
> > +- compatible : Should be the name of the chip, see the "m25p_ids" table
> > in + drivers/mtd/devices/m25p80.c
>
> Two things wrong with this:
Damn, I just sent a V3 a minute ago. Please ignore that V3 then, since V4 will
come of course, sorry about the noise. Let's discuss this properly.
> - Bindings are not Linux specific, so the docs should not be based on Linux.
Correct. Can you please advise how to formulate the "compatible" property then?
> - This doesn't follow the existing user which is "spansion,m25p80"
It doesn't, but the driver does support many other chips as well. I wasn't quite
sure how to go about that either. Any help would be appreciated, I gotta admit
I'm still a bit lost in all the devicetree stuff.
> Rob
[...]
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Artem Bityutskiy
<artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
David Woodhouse
<david.woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
dedekind1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH V2] mtd: m25p80: Make fast read configurable via DT
Date: Mon, 23 Jul 2012 04:07:18 +0200 [thread overview]
Message-ID: <201207230407.18747.marex@denx.de> (raw)
In-Reply-To: <500CB097.4000507-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Dear Rob Herring,
> +devicetree-discuss
>
> On 07/22/2012 08:20 PM, Marek Vasut wrote:
> > Add DT property "m25p,fast-read" that signalises the particular
> > chip supports "fast read" opcode.
> >
> > NOTE: I'm not sure where to document this property, as m25p80 is
> >
> > a simple DT device. Any hints please?
> >
> > Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> > Cc: Artem Bityutskiy <artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Cc: David Woodhouse <david.woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> >
> > Documentation/devicetree/bindings/mtd/m25p80.txt | 27
> > ++++++++++++++++++ drivers/mtd/devices/m25p80.c |
> > 32 +++++++++++++--------- 2 files changed, 46 insertions(+), 13
> > deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/mtd/m25p80.txt
> >
> > V2: Add documentation for the DT property. (Thanks Rob Herring for
> > helping!)
> >
> > Supersedes [PATCH 3/3] [RFC] mtd: m25p80: Make fast read configurable
> > via DT
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/m25p80.txt
> > b/Documentation/devicetree/bindings/mtd/m25p80.txt new file mode 100644
> > index 0000000..e05d9b8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/m25p80.txt
> > @@ -0,0 +1,27 @@
> > +* MTD SPI driver for ST M25Pxx (and similar) serial flash chips
> > +
> > +Required properties:
> > +- #address-cells, #size-cells : Must be present if the device has
> > sub-nodes + representing partitions.
> > +- compatible : Should be the name of the chip, see the "m25p_ids" table
> > in + drivers/mtd/devices/m25p80.c
>
> Two things wrong with this:
Damn, I just sent a V3 a minute ago. Please ignore that V3 then, since V4 will
come of course, sorry about the noise. Let's discuss this properly.
> - Bindings are not Linux specific, so the docs should not be based on Linux.
Correct. Can you please advise how to formulate the "compatible" property then?
> - This doesn't follow the existing user which is "spansion,m25p80"
It doesn't, but the driver does support many other chips as well. I wasn't quite
sure how to go about that either. Any help would be appreciated, I gotta admit
I'm still a bit lost in all the devicetree stuff.
> Rob
[...]
next prev parent reply other threads:[~2012-07-23 2:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 1:20 [PATCH V2] mtd: m25p80: Make fast read configurable via DT Marek Vasut
2012-07-23 1:22 ` Marek Vasut
2012-07-23 2:01 ` Rob Herring
2012-07-23 2:01 ` Rob Herring
2012-07-23 2:07 ` Marek Vasut [this message]
2012-07-23 2:07 ` Marek Vasut
2012-07-30 13:59 ` Marek Vasut
2012-07-30 13:59 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207230407.18747.marex@denx.de \
--to=marex@denx.de \
--cc=artem.bityutskiy@linux.intel.com \
--cc=david.woodhouse@intel.com \
--cc=dedekind1@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-mtd@lists.infradead.org \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.