All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: lenb@kernel.org, "Kirill A. Shutemov" <kirill@shutemov.name>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [Resend][PATCH] ACPI / PM: Fix build warning in sleep.c for CONFIG_ACPI_SLEEP unset
Date: Mon, 23 Jul 2012 12:29:10 -0700	[thread overview]
Message-ID: <20120723192910.GD2491@linux.vnet.ibm.com> (raw)
In-Reply-To: <201207232101.02472.rjw@sisk.pl>

On Mon, Jul 23, 2012 at 09:01:02PM +0200, Rafael J. Wysocki wrote:
> 
> If CONFIG_ACPI_SLEEP is unset, the compiler complains that
> pwr_btn_event_pending is defined but not used.  To silence the
> warning, move the definition of pwr_btn_event_pending under an
> appropriate #ifdef.
> 
> Reported-by: Paul E. McKenney <paul.mckenney@linaro.org>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

Tested-by: Paul E. McKenney <paul.mckenney@linaro.org>

> ---
>  drivers/acpi/sleep.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux/drivers/acpi/sleep.c
> ===================================================================
> --- linux.orig/drivers/acpi/sleep.c
> +++ linux/drivers/acpi/sleep.c
> @@ -57,7 +57,6 @@ MODULE_PARM_DESC(gts, "Enable evaluation
>  MODULE_PARM_DESC(bfs, "Enable evaluation of _BFS on resume".);
> 
>  static u8 sleep_states[ACPI_S_STATE_COUNT];
> -static bool pwr_btn_event_pending;
> 
>  static void acpi_sleep_tts_switch(u32 acpi_state)
>  {
> @@ -110,6 +109,7 @@ static int acpi_sleep_prepare(u32 acpi_s
> 
>  #ifdef CONFIG_ACPI_SLEEP
>  static u32 acpi_target_sleep_state = ACPI_STATE_S0;
> +static bool pwr_btn_event_pending;
> 
>  /*
>   * The ACPI specification wants us to save NVS memory regions during hibernation
> 


  reply	other threads:[~2012-07-23 19:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-21 21:41 [PATCH] acpi: fix pwr_btn_event_pending build error Paul E. McKenney
2012-07-21 21:41 ` Paul E. McKenney
2012-07-21 21:52 ` Kirill A. Shutemov
2012-07-21 23:37   ` Paul E. McKenney
2012-07-22  0:08     ` Kirill A. Shutemov
2012-07-22  4:10       ` Paul E. McKenney
2012-07-22  4:10         ` Paul E. McKenney
2012-07-22 17:40         ` Rafael J. Wysocki
2012-07-22 17:40           ` Rafael J. Wysocki
2012-07-22 20:28           ` Paul E. McKenney
2012-07-22 20:28             ` Paul E. McKenney
2012-07-23 18:58             ` Rafael J. Wysocki
2012-07-23 18:58               ` Rafael J. Wysocki
2012-07-23 19:01             ` [Resend][PATCH] ACPI / PM: Fix build warning in sleep.c for CONFIG_ACPI_SLEEP unset Rafael J. Wysocki
2012-07-23 19:29               ` Paul E. McKenney [this message]
2012-07-26 23:28                 ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120723192910.GD2491@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=kirill@shutemov.name \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.