remove dependency on PyXML from xen?

remove dependency on PyXML from xen?

[M A Young]

Fedora is keen to stop using PyXML and I have been sent a bug report
https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a patch 
to remove the use of XMLPrettyPrint in tools/python/xen/xm/create.py . I 
am going to try this in the Fedora build, but I was wondering if it makes 
sense to do this in the official xen releases as well.

 	Michael Young

Re: remove dependency on PyXML from xen?

[Konrad Rzeszutek Wilk]

On Tue, Jul 24, 2012 at 08:04:30PM +0100, M A Young wrote:
> Fedora is keen to stop using PyXML and I have been sent a bug report
> https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a
> patch to remove the use of XMLPrettyPrint in
> tools/python/xen/xm/create.py . I am going to try this in the Fedora
> build, but I was wondering if it makes sense to do this in the
> official xen releases as well.

Yes.

Re: remove dependency on PyXML from xen?

[Ian Campbell]

On Tue, 2012-07-24 at 20:36 +0100, Konrad Rzeszutek Wilk wrote:
> On Tue, Jul 24, 2012 at 08:04:30PM +0100, M A Young wrote:
> > Fedora is keen to stop using PyXML and I have been sent a bug report
> > https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a
> > patch to remove the use of XMLPrettyPrint in
> > tools/python/xen/xm/create.py . I am going to try this in the Fedora
> > build, but I was wondering if it makes sense to do this in the
> > official xen releases as well.
> 
> Yes.

Agreed.

According to the bug we've already moved from PyXML to lxml
(22235:b8cc53d22545 from the looks of it) and simply missed this one use
of PyXML.

Ian.

[PATCH] Re: remove dependency on PyXML from xen?

[M A Young]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 790 bytes --]

On Wed, 25 Jul 2012, Ian Campbell wrote:

> On Tue, 2012-07-24 at 20:36 +0100, Konrad Rzeszutek Wilk wrote:
>> On Tue, Jul 24, 2012 at 08:04:30PM +0100, M A Young wrote:
>>> Fedora is keen to stop using PyXML and I have been sent a bug report
>>> https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a
>>> patch to remove the use of XMLPrettyPrint in
>>> tools/python/xen/xm/create.py . I am going to try this in the Fedora
>>> build, but I was wondering if it makes sense to do this in the
>>> official xen releases as well.
>>
>> Yes.
>
> Agreed.
>
> According to the bug we've already moved from PyXML to lxml
> (22235:b8cc53d22545 from the looks of it) and simply missed this one use
> of PyXML.

Here is the patch from that bug (trivially) rebased to 4.2.

 	Michael Young

[-- Attachment #2: Type: TEXT/PLAIN, Size: 801 bytes --]

Replace the use of XMLPrettyPrint from PyXML in xm with stdlib functionality.
This was reported by Toshio Ernie Kuratomi at
https://bugzilla.redhat.com/show_bug.cgi?id=842843

Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
--- xen-4.2.0/tools/python/xen/xm/create.py.orig	2012-05-12 16:40:48.000000000 +0100
+++ xen-4.2.0/tools/python/xen/xm/create.py	2012-08-12 17:59:56.464270707 +0100
@@ -1543,8 +1543,7 @@
             SXPPrettyPrint.prettyprint(config)
 
         if opts.vals.xmldryrun and serverType == SERVER_XEN_API:
-            from xml.dom.ext import PrettyPrint as XMLPrettyPrint
-            XMLPrettyPrint(doc)
+            print doc.toprettyxml()
 
     if opts.vals.dryrun or opts.vals.xmldryrun:
         return                                               

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Re: remove dependency on PyXML from xen?

[Ian Campbell]

On Sun, 2012-08-12 at 19:03 +0100, M A Young wrote:
> On Wed, 25 Jul 2012, Ian Campbell wrote:
> 
> > On Tue, 2012-07-24 at 20:36 +0100, Konrad Rzeszutek Wilk wrote:
> >> On Tue, Jul 24, 2012 at 08:04:30PM +0100, M A Young wrote:
> >>> Fedora is keen to stop using PyXML and I have been sent a bug report
> >>> https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a
> >>> patch to remove the use of XMLPrettyPrint in
> >>> tools/python/xen/xm/create.py . I am going to try this in the Fedora
> >>> build, but I was wondering if it makes sense to do this in the
> >>> official xen releases as well.
> >>
> >> Yes.
> >
> > Agreed.
> >
> > According to the bug we've already moved from PyXML to lxml
> > (22235:b8cc53d22545 from the looks of it) and simply missed this one use
> > of PyXML.
> 
> Here is the patch from that bug (trivially) rebased to 4.2.

Seems good to me, although xend is deprecated this patch is pretty
simple and the goal a useful one.

Ian.

Re: [PATCH] Re: remove dependency on PyXML from xen?

[Ian Campbell]

On Sun, 2012-08-12 at 19:03 +0100, M A Young wrote:
> On Wed, 25 Jul 2012, Ian Campbell wrote:
> 
> > On Tue, 2012-07-24 at 20:36 +0100, Konrad Rzeszutek Wilk wrote:
> >> On Tue, Jul 24, 2012 at 08:04:30PM +0100, M A Young wrote:
> >>> Fedora is keen to stop using PyXML and I have been sent a bug report
> >>> https://bugzilla.redhat.com/show_bug.cgi?id=842843 which includes a
> >>> patch to remove the use of XMLPrettyPrint in
> >>> tools/python/xen/xm/create.py . I am going to try this in the Fedora
> >>> build, but I was wondering if it makes sense to do this in the
> >>> official xen releases as well.
> >>
> >> Yes.
> >
> > Agreed.
> >
> > According to the bug we've already moved from PyXML to lxml
> > (22235:b8cc53d22545 from the looks of it) and simply missed this one use
> > of PyXML.
> 
> Here is the patch from that bug (trivially) rebased to 4.2.

Acked-by: Ian Campbell <ian.campbell@citrix.com>

and pushed. Is the following section of README still accurate? At least
the mention of "PyXML" seems wrong to me.
        
        Python Runtime Libraries
        ========================
        
        Xend (the Xen daemon) has the following runtime dependencies:
        
            * Python 2.3 or later.
              In some distros, the XML-aspects to the standard library
              (xml.dom.minidom etc) are broken out into a separate python-xml package.
              This is also required.
              In more recent versions of Debian and Ubuntu the XML-aspects are included
              in the base python package however (python-xml has been removed
              from Debian in squeeze and from Ubuntu in intrepid).
        
                  URL:    http://www.python.org/
                  Debian: python
        
            * For optional SSL support, pyOpenSSL:
                  URL:    http://pyopenssl.sourceforge.net/
                  Debian: python-pyopenssl
        
            * For optional PAM support, PyPAM:
                  URL:    http://www.pangalactic.org/PyPAM/
                  Debian: python-pam
        
            * For optional XenAPI support in XM, PyXML:
                  URL:    http://codespeak.net/lxml/
                  Debian: python-lxml
                  YUM:    python-lxml

Re: [PATCH] Re: remove dependency on PyXML from xen?

[M A Young]

On Fri, 17 Aug 2012, Ian Campbell wrote:

> ...
> and pushed. Is the following section of README still accurate? At least
> the mention of "PyXML" seems wrong to me.
>
>        Python Runtime Libraries
>        ========================
>
>        Xend (the Xen daemon) has the following runtime dependencies:
>
>            * Python 2.3 or later.
>              In some distros, the XML-aspects to the standard library
>              (xml.dom.minidom etc) are broken out into a separate python-xml package.
>              This is also required.
>              In more recent versions of Debian and Ubuntu the XML-aspects are included
>              in the base python package however (python-xml has been removed
>              from Debian in squeeze and from Ubuntu in intrepid).
>
>                  URL:    http://www.python.org/
>                  Debian: python
>
>            * For optional SSL support, pyOpenSSL:
>                  URL:    http://pyopenssl.sourceforge.net/
>                  Debian: python-pyopenssl
>
>            * For optional PAM support, PyPAM:
>                  URL:    http://www.pangalactic.org/PyPAM/
>                  Debian: python-pam
>
>            * For optional XenAPI support in XM, PyXML:
>                  URL:    http://codespeak.net/lxml/
>                  Debian: python-lxml
>                  YUM:    python-lxml

Yes, it should be lxml not PyXML. The link could be upgraded as well as 
http://codespeak.net/lxml/ redirects to http://lxml.de/ .

I also found mention of PyXML in tools/python/logging/logging-0.4.9.2/ in 
the files README.txt, python_logging.html, and test/logrecv.py (in an 
error message) as a dependency for ZSI though I don't think xen ever uses 
the code.

 	Michael Young

[PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?)

[Ian Campbell]

On Mon, 2012-08-20 at 20:44 +0100, M A Young wrote:
> On Fri, 17 Aug 2012, Ian Campbell wrote:
> 
> > ...
> > and pushed. Is the following section of README still accurate? At least
> > the mention of "PyXML" seems wrong to me.
> >
> >        Python Runtime Libraries
> >        ========================
> >
> >        Xend (the Xen daemon) has the following runtime dependencies:
> >
> >            * Python 2.3 or later.
> >              In some distros, the XML-aspects to the standard library
> >              (xml.dom.minidom etc) are broken out into a separate python-xml package.
> >              This is also required.
> >              In more recent versions of Debian and Ubuntu the XML-aspects are included
> >              in the base python package however (python-xml has been removed
> >              from Debian in squeeze and from Ubuntu in intrepid).
> >
> >                  URL:    http://www.python.org/
> >                  Debian: python
> >
> >            * For optional SSL support, pyOpenSSL:
> >                  URL:    http://pyopenssl.sourceforge.net/
> >                  Debian: python-pyopenssl
> >
> >            * For optional PAM support, PyPAM:
> >                  URL:    http://www.pangalactic.org/PyPAM/
> >                  Debian: python-pam
> >
> >            * For optional XenAPI support in XM, PyXML:
> >                  URL:    http://codespeak.net/lxml/
> >                  Debian: python-lxml
> >                  YUM:    python-lxml
> 
> Yes, it should be lxml not PyXML. The link could be upgraded as well as 
> http://codespeak.net/lxml/ redirects to http://lxml.de/ .

Thanks, patch below.

> I also found mention of PyXML in tools/python/logging/logging-0.4.9.2/ in 
> the files README.txt, python_logging.html, and test/logrecv.py (in an 
> error message) as a dependency for ZSI though I don't think xen ever uses 
> the code.

Great, yet another imported source base!

It seems like the functionality is now part of mainline python. From
looking at Debian it seems that python 2.5+ contains this module
directly.

According to tools/python/logging/setup.py it is at least only installed
if the system version of python does not support it.

AFAICT this is only used by xend and the bit which uses pyxml is not
used.

8<--------------------------

# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1345537817 -3600
# Node ID 7ba9eaf898afafac6cf3956d01c86b861ec5d853
# Parent  b51f4c5a08480297d13439e66793a9002d9b49e9
README: Update references to PyXML to lxml

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff -r b51f4c5a0848 -r 7ba9eaf898af README
--- a/README	Tue Aug 21 09:20:41 2012 +0100
+++ b/README	Tue Aug 21 09:30:17 2012 +0100
@@ -148,9 +148,9 @@ Xend (the Xen daemon) has the following 
           URL:    http://www.pangalactic.org/PyPAM/
           Debian: python-pam
 
-    * For optional XenAPI support in XM, PyXML:
-          URL:    http://codespeak.net/lxml/
-	  Debian: python-lxml
+    * For optional XenAPI support in XM, lxml:
+          URL:    http://lxml.de/
+          Debian: python-lxml
           YUM:    python-lxml

[PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?)

[Ian Jackson]

Ian Campbell writes ("[Xen-devel] [PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?)"):
> README: Update references to PyXML to lxml

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Re: [PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?)

[Ian Campbell]

On Thu, 2012-08-30 at 16:00 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH] README: Update references to PyXML to lxml (Was: Re: [PATCH] Re: remove dependency on PyXML from xen?)"):
> > README: Update references to PyXML to lxml
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Applied, thanks.