From: Paul Mundt <lethal@linux-sh.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linux-sh list <linux-sh@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH] sh: pfc: Fix build issues in pinctrl.c
Date: Sat, 28 Jul 2012 00:29:12 +0000 [thread overview]
Message-ID: <20120728002911.GG30468@linux-sh.org> (raw)
In-Reply-To: <201207280007.04480.rjw@sisk.pl>
On Sat, Jul 28, 2012 at 12:07:04AM +0200, Rafael J. Wysocki wrote:
>
> First off, drivers/sh/pfc/pinctrl.c doesn't build after commit
> 5d589b0 (pinctrl: remove pinctrl_remove_gpio_range), because
> sh_pfc_pinctrl_remove() uses the function that has been removed by
> that commit. Fix this by removing the pinctrl_remove_gpio_range()
> call, which is not necessary any more, from sh_pfc_pinctrl_remove().
>
> Second, the compiler complains correctly that there's an unused
> local variable in sh_pfc_pinconf_set(). Fix this by removing the
> definition of that variable.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Already fixed in my tree, as pointed out when Iwamatsu-san sent the same
patch.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "Linux-sh list" <linux-sh@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH] sh: pfc: Fix build issues in pinctrl.c
Date: Sat, 28 Jul 2012 09:29:12 +0900 [thread overview]
Message-ID: <20120728002911.GG30468@linux-sh.org> (raw)
In-Reply-To: <201207280007.04480.rjw@sisk.pl>
On Sat, Jul 28, 2012 at 12:07:04AM +0200, Rafael J. Wysocki wrote:
>
> First off, drivers/sh/pfc/pinctrl.c doesn't build after commit
> 5d589b0 (pinctrl: remove pinctrl_remove_gpio_range), because
> sh_pfc_pinctrl_remove() uses the function that has been removed by
> that commit. Fix this by removing the pinctrl_remove_gpio_range()
> call, which is not necessary any more, from sh_pfc_pinctrl_remove().
>
> Second, the compiler complains correctly that there's an unused
> local variable in sh_pfc_pinconf_set(). Fix this by removing the
> definition of that variable.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Already fixed in my tree, as pointed out when Iwamatsu-san sent the same
patch.
next prev parent reply other threads:[~2012-07-28 0:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 22:07 [PATCH] sh: pfc: Fix build issues in pinctrl.c Rafael J. Wysocki
2012-07-27 22:07 ` Rafael J. Wysocki
2012-07-28 0:29 ` Paul Mundt [this message]
2012-07-28 0:29 ` Paul Mundt
2012-07-28 13:13 ` Rafael J. Wysocki
2012-07-28 13:13 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120728002911.GG30468@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.