From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Len Brown <lenb@kernel.org>
Cc: Len Brown <len.brown@intel.com>,
linux-pm@lists.linux-foundation.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] x86 idle APM: delete apm_cpu_idle()
Date: Sat, 28 Jul 2012 11:11:48 +0100 [thread overview]
Message-ID: <20120728111148.39ff7230@ultron> (raw)
In-Reply-To: <f8c928c1d43f5c4d1342bd05ca29c8ea788726b8.1343428708.git.len.brown@intel.com>
On Fri, 27 Jul 2012 18:42:53 -0400
Len Brown <lenb@kernel.org> wrote:
> From: Len Brown <len.brown@intel.com>
>
> The APM idle feature to call into the BIOS
> is known to break some machines, and it has dubious benefit
> on the (decades old) machines it doesn't break.
You mean "doesn't fit my current plan" I think. I see almost no bugzilla
APM reports. It's been solid for years.
It makes a big difference on older systems as it drops the clock. If we
are going to drop this we should probaly also drop APM support entirely
and 386/486 support.
If not IMHO it should stay. Various embedded platforms are still using
ancient hardware setups.
This is a small stable piece of code that has required no maintainance in
years
Furthermore we have a feature removal process. Mark it down to be removed
in July 2013 if there are no objections, and then wait as per proper
process.
NAK
Alan
WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Len Brown <lenb@kernel.org>
Cc: x86@kernel.org, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 2/4] x86 idle APM: delete apm_cpu_idle()
Date: Sat, 28 Jul 2012 11:11:48 +0100 [thread overview]
Message-ID: <20120728111148.39ff7230@ultron> (raw)
In-Reply-To: <f8c928c1d43f5c4d1342bd05ca29c8ea788726b8.1343428708.git.len.brown@intel.com>
On Fri, 27 Jul 2012 18:42:53 -0400
Len Brown <lenb@kernel.org> wrote:
> From: Len Brown <len.brown@intel.com>
>
> The APM idle feature to call into the BIOS
> is known to break some machines, and it has dubious benefit
> on the (decades old) machines it doesn't break.
You mean "doesn't fit my current plan" I think. I see almost no bugzilla
APM reports. It's been solid for years.
It makes a big difference on older systems as it drops the clock. If we
are going to drop this we should probaly also drop APM support entirely
and 386/486 support.
If not IMHO it should stay. Various embedded platforms are still using
ancient hardware setups.
This is a small stable piece of code that has required no maintainance in
years
Furthermore we have a feature removal process. Mark it down to be removed
in July 2013 if there are no objections, and then wait as per proper
process.
NAK
Alan
next prev parent reply other threads:[~2012-07-28 10:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 22:42 [0/4] pm_idle, default_idle cleanup Len Brown
2012-07-27 22:42 ` [PATCH 1/4] Revert "x86 idle APM: deprecate CONFIG_APM_CPU_IDLE" to prepare for actual removal Len Brown
2012-07-27 22:42 ` [PATCH 2/4] x86 idle APM: delete apm_cpu_idle() Len Brown
2012-07-28 10:11 ` Alan Cox [this message]
2012-07-28 10:11 ` Alan Cox
2012-07-29 2:21 ` Len Brown
2012-07-29 2:21 ` Len Brown
2012-07-27 22:42 ` [PATCH 3/4] x86, idle: make default_idle() static Len Brown
2012-07-27 22:42 ` [PATCH 4/4] PM: cleanup: stop mandating that platforms export (pm_idle)() Len Brown
2012-08-07 23:26 ` [linux-pm] " Kevin Hilman
2012-08-07 23:26 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120728111148.39ff7230@ultron \
--to=alan@lxorguk.ukuu.org.uk \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.